You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/22 07:37:29 UTC
[GitHub] [bookkeeper] poorbarcode opened a new pull request #3133: Issue 3132# Add a api for delete empty zookeeper node
poorbarcode opened a new pull request #3133:
URL: https://github.com/apache/bookkeeper/pull/3133
Descriptions of the changes in this PR:
### Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
### Changes
(Describe: what changes you have made)
Master Issue: #<master-issue-number>
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] poorbarcode commented on a change in pull request #3133: [feature] [distributedlog] Add a api for delete empty zookeeper node
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on a change in pull request #3133:
URL: https://github.com/apache/bookkeeper/pull/3133#discussion_r836018365
##########
File path: stream/distributedlog/core/src/main/java/org/apache/distributedlog/impl/metadata/ZKLogStreamMetadataStore.java
##########
@@ -680,6 +680,40 @@ public void processResult(int rc, String path, Object ctx) {
return promise;
}
+ @Override
+ public CompletableFuture<Boolean> deleteLogUnRecursive(URI uri, final String logName) {
Review comment:
> the distributed log will create a lot of metadata paths under the log, you can check the getLog method. Looks like the deleteLogUnRecursive will fail because we only delete the log path?
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on a change in pull request #3133: [feature] [distributedlog] Add a api for delete empty zookeeper node
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #3133:
URL: https://github.com/apache/bookkeeper/pull/3133#discussion_r836017741
##########
File path: stream/distributedlog/core/src/main/java/org/apache/distributedlog/impl/metadata/ZKLogStreamMetadataStore.java
##########
@@ -680,6 +680,40 @@ public void processResult(int rc, String path, Object ctx) {
return promise;
}
+ @Override
+ public CompletableFuture<Boolean> deleteLogUnRecursive(URI uri, final String logName) {
Review comment:
the distributed log will create a lot of metadata paths under the log, you can check the getLog method. Looks like the deleteLogUnRecursive will fail because we only delete the log path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org