You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/07/29 00:55:52 UTC
[jclouds-labs-openstack] Ensures the immutable maps are not copied
over in the constructor. (#122)
More simple and efficient when supported in jclouds.
Not supported yet: https://github.com/jclouds/jclouds/pull/455
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack neutron-immutablemap-nocopy
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/122
-- Commit Summary --
* Ensures the immutable maps are not copied over in the constructor (more simple and efficient when supported in jclouds)
-- File Changes --
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2/domain/Port.java (10)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/122.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/122.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1497](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1497/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50414614
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Zack Shoylev <no...@github.com>.
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50547889
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #345](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/345/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50414733
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
@jdaggett @everett-toews We can still get this in for 1.8.0 if you like, but I'd need a quick review from someone with more OpenStack expertise, and it looks like Zack's busy.
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50546072
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #1502](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1502/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50521795
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Zack Shoylev <no...@github.com>.
Nevermind, Single commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50547485
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Zack Shoylev <no...@github.com>.
Expected failures
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50415777
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
Great, thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50547486
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
@zack-shoylev: lookin' good?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50528247
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Zack Shoylev <no...@github.com>.
About to rebase! It should be ready to merge after and is fairly simple.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50547378
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
+1 (modulo the failures etc.) - looks good to me, pending jclouds/jclouds#455.
Thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50420107
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #346](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/346/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50522346
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
Reopened #122.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#event-146876975
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Zack Shoylev <no...@github.com>.
Closed #122.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#event-146975158
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
@zack-shoylev Could you test this again locally, now that the upstream change is in? We should also bounce this when the current DEV@cloud build completes...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50515174
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
Here goes...bounce!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#issuecomment-50520200
Re: [jclouds-labs-openstack] Ensures the immutable maps are not
copied over in the constructor. (#122)
Posted by Andrew Phillips <no...@github.com>.
Closed #122.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/122#event-146876961