You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/12/02 06:06:40 UTC

[kudu-CR] KUDU-625 - Make write transctions abort in mvcc, by default

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5320

Change subject: KUDU-625 - Make write transctions abort in mvcc, by default
......................................................................

KUDU-625 - Make write transctions abort in mvcc, by default

This patch addresses a long standing TODO where we would commit
transactions on the WriteTransactionState dctor instead of
aborting them.

Besides changing WriteTransactionState::Reset() to call
CommitOrAbort(Transaction::ABORTED) this also required that
we change TabletBootstrap to explicitely call
tx_state.CommitOrAbort(Transaction::COMMITTED) in
PlayWriteRequest().

I ran raft_consensus-itest and exactly_once_writes-itest in slow
mode, asan, for 1000 loops on dist-test. Results:

exactly_once_writes-itest: http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678
raft_consensus-itest     : http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678

Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
---
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/transactions/write_transaction.cc
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5320/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change.

Change subject: KUDU-625 - Make write transactions abort in mvcc, by default
......................................................................


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.

David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-625 - Make write transactions abort in mvcc, by default
......................................................................


Patch Set 5:

fixed typos, keeping the +1

-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Todd Lipcon has posted comments on this change.

Change subject: KUDU-625 - Make write transactions abort in mvcc, by default
......................................................................


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change.

Change subject: KUDU-625 - Make write transactions abort in mvcc, by default
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

Just a couple of nits in the commit message, otherwise lgtm

http://gerrit.cloudera.org:8080/#/c/5320/5//COMMIT_MSG
Commit Message:

PS5, Line 11: explicitely
nit: explicitly


PS5, Line 16: explicitely
nit: explicitly


-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.

David Ribeiro Alves has submitted this change and it was merged.

Change subject: KUDU-625 - Make write transactions abort in mvcc, by default
......................................................................


KUDU-625 - Make write transactions abort in mvcc, by default

This patch addresses a long standing TODO where we would commit
transactions on the WriteTransactionState dctor instead of
aborting them, if they hadn't been explicitly
committed/aborted.

Besides changing WriteTransactionState::Reset() to call
CommitOrAbort(Transaction::ABORTED) this also required a change
to TabletBootstrap to explicitly call
tx_state.CommitOrAbort(Transaction::COMMITTED) in
PlayWriteRequest().

I ran raft_consensus-itest and exactly_once_writes-itest in slow
mode, asan, for 1000 loops on dist-test. No failures.
Results:

exactly_once_writes-itest: http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678
raft_consensus-itest     : http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678

Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Reviewed-on: http://gerrit.cloudera.org:8080/5320
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/transactions/write_transaction.cc
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Alexey Serbin: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5320

to look at the new patch set (#3).

Change subject: KUDU-625 - Make write transactions abort in mvcc, by default
......................................................................

KUDU-625 - Make write transactions abort in mvcc, by default

This patch addresses a long standing TODO where we would commit
transactions on the WriteTransactionState dctor instead of
aborting them, if they hadn't been explicitely
committed/aborted.

Besides changing WriteTransactionState::Reset() to call
CommitOrAbort(Transaction::ABORTED) this also required a change
to TabletBootstrap to explicitely call
tx_state.CommitOrAbort(Transaction::COMMITTED) in
PlayWriteRequest().

I ran raft_consensus-itest and exactly_once_writes-itest in slow
mode, asan, for 1000 loops on dist-test. No failures.
Results:

exactly_once_writes-itest: http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678
raft_consensus-itest     : http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678

Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
---
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/transactions/write_transaction.cc
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5320/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>