You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "j143 (via GitHub)" <gi...@apache.org> on 2025/08/24 03:11:32 UTC
[PR] [SYSTEMDS-3907] Tee OOC operator [systemds]
j143 opened a new pull request, #2315:
URL: https://github.com/apache/systemds/pull/2315
Hi! I tried to rewrite and add tee operator in the graph. somewhere the variable copy is missing. so, the outputs for the tee operator are coming as null.
Some workarounds I've used in a couple of places (in Reorg.java to avoid undoing the rewiring).
Transpose OOC is also implemented (working).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3907] Tee OOC operator [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2315:
URL: https://github.com/apache/systemds/pull/2315#issuecomment-3227506413
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2315?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `84.18605%` with `34 lines` in your changes missing coverage. Please review.
:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`main@9e23ad8`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
:warning: Report is 8 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2315?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/sysds/hops/rewrite/RewriteInjectOOCTee.java](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fhops%2Frewrite%2FRewriteInjectOOCTee.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL2hvcHMvcmV3cml0ZS9SZXdyaXRlSW5qZWN0T09DVGVlLmphdmE=) | 81.92% | [6 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/main/java/org/apache/sysds/hops/TeeOp.java](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fhops%2FTeeOp.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL2hvcHMvVGVlT3AuamF2YQ==) | 68.75% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ds/runtime/instructions/ooc/TeeOOCInstruction.java](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Finstructions%2Fooc%2FTeeOOCInstruction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvaW5zdHJ1Y3Rpb25zL29vYy9UZWVPT0NJbnN0cnVjdGlvbi5qYXZh) | 89.18% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...time/instructions/ooc/TransposeOOCInstruction.java](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Finstructions%2Fooc%2FTransposeOOCInstruction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvaW5zdHJ1Y3Rpb25zL29vYy9UcmFuc3Bvc2VPT0NJbnN0cnVjdGlvbi5qYXZh) | 87.50% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/main/java/org/apache/sysds/lops/Tee.java](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Flops%2FTee.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL2xvcHMvVGVlLmphdmE=) | 92.85% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage ? 72.28%
Complexity ? 46695
=======================================
Files ? 1500
Lines ? 177041
Branches ? 34790
=======================================
Hits ? 127976
Misses ? 39413
Partials ? 9652
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2315?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3907] Tee OOC operator [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2315:
URL: https://github.com/apache/systemds/pull/2315#issuecomment-3227744328
Thanks for the great patch @j143 - overall, this looks very solid. I would recommend to move the TeeOp into the existing DataOp though, and split the OOC transpose into a separate PR (which we can test and merge separately).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3907] Tee OOC operator [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 closed pull request #2315: [SYSTEMDS-3907] Tee OOC operator
URL: https://github.com/apache/systemds/pull/2315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3907] Tee OOC operator [systemds]
Posted by "j143 (via GitHub)" <gi...@apache.org>.
j143 commented on PR #2315:
URL: https://github.com/apache/systemds/pull/2315#issuecomment-3227429258
Hi @mboehm7 , could you please check this once. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org