[GitHub] [kylin] nichunen commented on a change in pull request #752: KYLIN-4091 support fast mode and simple mode for running CI

[GitBox <gi...@apache.org>]

nichunen commented on a change in pull request #752: KYLIN-4091 support fast mode and simple mode for running CI
URL: https://github.com/apache/kylin/pull/752#discussion_r308664131
 
 

 ##########
 File path: kylin-it/src/test/java/org/apache/kylin/provision/BuildCubeWithEngine.java
 ##########
 @@ -398,15 +431,53 @@ private Boolean mergeSegment(String cubeName, long startDate, long endDate) thro
         return Boolean.valueOf(ExecutableState.SUCCEED == state);
     }
 
-    private Boolean buildSegment(String cubeName, long startDate, long endDate) throws Exception {
+    private Boolean buildSegment(String cubeName, long startDate, long endDate, Boolean isEmpty) throws Exception {
         CubeInstance cubeInstance = cubeManager.getCube(cubeName);
         CubeSegment segment = cubeManager.appendSegment(cubeInstance, new TSRange(0L, endDate));
         DefaultChainedExecutable job = EngineFactory.createBatchCubingJob(segment, "TEST");
         jobService.addJob(job);
+        if (fastBuildMode) {
+            jobSegmentMap.put(job.getId(), segment);
+            jobCheckActionMap.put(job.getId(), isEmpty ? "checkEmptySegRangeInfo": "checkNormalSegRangeInfo");
+            return true;
+        }
         ExecutableState state = waitForJob(job.getId());
         return Boolean.valueOf(ExecutableState.SUCCEED == state);
     }
+    private Boolean buildSegment(String cubeName, long startDate, long endDate) throws Exception {
+        return buildSegment(cubeName, startDate, endDate, false);
+    }
 
+    private Boolean checkJobState() throws Exception {
+        List<String> jobIds = jobService.getAllJobIds();
 
 Review comment:
   why not use "getAllJobIdsInCache" to speed up?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services