You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "jstastny-cz (via GitHub)" <gi...@apache.org> on 2023/11/03 12:25:43 UTC
[PR] kie-issues#599: set projectKey for sonar analysis [incubator-kie-kogito-pipelines]
jstastny-cz opened a new pull request, #1116:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1116
apache/incubator-kie-issues#599
Explicitly setting sonar.projectKey in PR checks and buildchain nightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#599: set projectKey for sonar analysis [incubator-kie-kogito-pipelines]
Posted by "radtriste (via GitHub)" <gi...@apache.org>.
radtriste commented on code in PR #1116:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1116#discussion_r1381831359
##########
dsl/scripts/pr_check.groovy:
##########
@@ -90,6 +90,7 @@ void launchStages() {
new MavenCommand(this)
.withProperty('sonar.login', "${TOKEN}")
.withProperty('sonar.organization', 'apache') // override what's in pom.xml for now
+ .withProperty('sonar.projectKey', env.SONAR_PROJECT_KEY)
Review Comment:
What happens if that env is not configured ?
##########
dsl/scripts/pr_check.groovy:
##########
@@ -90,6 +90,7 @@ void launchStages() {
new MavenCommand(this)
.withProperty('sonar.login', "${TOKEN}")
.withProperty('sonar.organization', 'apache') // override what's in pom.xml for now
+ .withProperty('sonar.projectKey', env.SONAR_PROJECT_KEY)
Review Comment:
What happens if that env is not configured ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#599: set projectKey for sonar analysis [incubator-kie-kogito-pipelines]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir merged PR #1116:
URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org