You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2019/05/17 16:25:22 UTC
[tomcat] branch master updated: Add comment to unreachable code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 21ee1c0 Add comment to unreachable code
21ee1c0 is described below
commit 21ee1c0b33aed7908a7aa5f415ff8775cfd92119
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri May 17 17:25:09 2019 +0100
Add comment to unreachable code
Identified by Coverity Scan
---
java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
index 0cd91ef..cdf0e82 100644
--- a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
+++ b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
@@ -81,6 +81,7 @@ public class WsRemoteEndpointImplServer extends WsRemoteEndpointImplBase {
} else {
this.handler = handler;
if (timeout > 0) {
+ // TODO This block in unreachable
// Register with timeout thread
timeoutExpiry = timeout + System.currentTimeMillis();
wsWriteTimeout.register(this);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch master updated: Add comment to unreachable code
Posted by Mark Thomas <ma...@apache.org>.
On 17/05/2019 18:08, Rémy Maucherat wrote:
> On Fri, May 17, 2019 at 6:27 PM Mark Thomas <markt@apache.org
> <ma...@apache.org>> wrote:
>
> On 17/05/2019 17:25, markt@apache.org <ma...@apache.org> wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > markt pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> > new 21ee1c0 Add comment to unreachable code
> > 21ee1c0 is described below
> >
> > commit 21ee1c0b33aed7908a7aa5f415ff8775cfd92119
> > Author: Mark Thomas <markt@apache.org <ma...@apache.org>>
> > AuthorDate: Fri May 17 17:25:09 2019 +0100
> >
> > Add comment to unreachable code
> >
> > Identified by Coverity Scan
> > ---
> >
> java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> > index 0cd91ef..cdf0e82 100644
> > ---
> a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> > +++
> b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> > @@ -81,6 +81,7 @@ public class WsRemoteEndpointImplServer extends
> WsRemoteEndpointImplBase {
> > } else {
> > this.handler = handler;
> > if (timeout > 0) {
> > + // TODO This block is unreachable
>
> It wasn't immediately obvious to me what to do with this so I added a
> comment as a marker.
>
>
> I don't remember what I meant to do there. I will investigate and fix it.
Thanks.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch master updated: Add comment to unreachable code
Posted by Rémy Maucherat <re...@apache.org>.
On Fri, May 17, 2019 at 6:27 PM Mark Thomas <ma...@apache.org> wrote:
> On 17/05/2019 17:25, markt@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > markt pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> > new 21ee1c0 Add comment to unreachable code
> > 21ee1c0 is described below
> >
> > commit 21ee1c0b33aed7908a7aa5f415ff8775cfd92119
> > Author: Mark Thomas <ma...@apache.org>
> > AuthorDate: Fri May 17 17:25:09 2019 +0100
> >
> > Add comment to unreachable code
> >
> > Identified by Coverity Scan
> > ---
> > java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> > index 0cd91ef..cdf0e82 100644
> > ---
> a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> > +++
> b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> > @@ -81,6 +81,7 @@ public class WsRemoteEndpointImplServer extends
> WsRemoteEndpointImplBase {
> > } else {
> > this.handler = handler;
> > if (timeout > 0) {
> > + // TODO This block is unreachable
>
> It wasn't immediately obvious to me what to do with this so I added a
> comment as a marker.
>
I don't remember what I meant to do there. I will investigate and fix it.
Rémy
Re: [tomcat] branch master updated: Add comment to unreachable code
Posted by Mark Thomas <ma...@apache.org>.
On 17/05/2019 17:25, markt@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 21ee1c0 Add comment to unreachable code
> 21ee1c0 is described below
>
> commit 21ee1c0b33aed7908a7aa5f415ff8775cfd92119
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Fri May 17 17:25:09 2019 +0100
>
> Add comment to unreachable code
>
> Identified by Coverity Scan
> ---
> java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> index 0cd91ef..cdf0e82 100644
> --- a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> +++ b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java
> @@ -81,6 +81,7 @@ public class WsRemoteEndpointImplServer extends WsRemoteEndpointImplBase {
> } else {
> this.handler = handler;
> if (timeout > 0) {
> + // TODO This block is unreachable
It wasn't immediately obvious to me what to do with this so I added a
comment as a marker.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org