[jira] [Resolved] (CALCITE-5038) Making AGGREGATE_ANY_PULL_UP_CONSTANTS's test case more rigorous

["Xurenhe (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xurenhe resolved CALCITE-5038.
------------------------------
    Resolution: Fixed

Fixed in [a81cfb2|https://github.com/apache/calcite/commit/a81cfb2ad001589929e190939cf4db928ebac386].

> Making AGGREGATE_ANY_PULL_UP_CONSTANTS's test case more rigorous
> ----------------------------------------------------------------
>
>                 Key: CALCITE-5038
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5038
>             Project: Calcite
>          Issue Type: Test
>          Components: tests
>            Reporter: Xurenhe
>            Assignee: Xurenhe
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Some test cases for AGGREGATE_ANY_PULL_UP_CONSTANTS aren't rigorous.
>  
> {code:java}
> //sql in testAggregateDynamicFunction
> select hiredate
> from sales.emp
> where sal is null and hiredate = current_timestamp
> group by sal, hiredate
> having count(*) > 3
>  {code}
> But we know that sal in table of sales.emp is not null, so this case should be changed to
>  
>  
> {code:java}
> //代码占位符
> select hiredate
> from sales.emp
> where mrg is null and hiredate = current_timestamp
> group by mrg, hiredate
> having count(*) > 3 {code}
>  
> Test case of *_testAggregateConstantKeyRule3_* has the same problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)