You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2012/05/09 22:03:49 UTC
[jira] [Created] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Tsz Wo (Nicholas), SZE created HADOOP-8375:
----------------------------------------------
Summary: test-patch should stop immediately once it has found compilation errors
Key: HADOOP-8375
URL: https://issues.apache.org/jira/browse/HADOOP-8375
Project: Hadoop Common
Issue Type: Improvement
Components: build
Reporter: Tsz Wo (Nicholas), SZE
It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273233#comment-13273233 ]
Hudson commented on HADOOP-8375:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1040 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/])
HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Fix For: 3.0.0
>
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8375:
----------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Status: Resolved (was: Patch Available)
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Fix For: 3.0.0
>
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8375:
----------------------------------------
Attachment: HADOOP-8375.txt
It is a bit ugly, and I can clean it up if need be, but it works.
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272814#comment-13272814 ]
Hudson commented on HADOOP-8375:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2298 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2298/])
HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Fix For: 3.0.0
>
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans reassigned HADOOP-8375:
-------------------------------------------
Assignee: Robert Joseph Evans
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271852#comment-13271852 ]
Hadoop QA commented on HADOOP-8375:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526217/HADOOP-8375.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/970//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/970//console
This message is automatically generated.
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271875#comment-13271875 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8375:
------------------------------------------------
How about we also move the javadoc check after javac?
{code}
@@ -903,7 +903,12 @@
checkJavadocWarnings
(( RESULT = RESULT + $? ))
checkJavacWarnings
-(( RESULT = RESULT + $? ))
+JAVAC_RET=$?
...
{code}
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272824#comment-13272824 ]
Hudson commented on HADOOP-8375:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2223 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2223/])
HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Fix For: 3.0.0
>
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273272#comment-13273272 ]
Hudson commented on HADOOP-8375:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1076 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1076/])
HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Fix For: 3.0.0
>
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272572#comment-13272572 ]
Hadoop QA commented on HADOOP-8375:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526379/HADOOP-8375.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/979//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/979//console
This message is automatically generated.
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-8375:
-------------------------------------------
Hadoop Flags: Reviewed
+1 patch looks good. Thanks a lot!
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272813#comment-13272813 ]
Hudson commented on HADOOP-8375:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2240 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2240/])
HADOOP-8375. test-patch should stop immediately once it has found compilation errors (bobby) (Revision 1336887)
Result = ABORTED
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336887
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Fix For: 3.0.0
>
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8375:
----------------------------------------
Target Version/s: 3.0.0
Status: Patch Available (was: Open)
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8375) test-patch should stop immediately
once it has found compilation errors
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8375:
----------------------------------------
Attachment: HADOOP-8375.txt
Javadocs check after javac check.
> test-patch should stop immediately once it has found compilation errors
> -----------------------------------------------------------------------
>
> Key: HADOOP-8375
> URL: https://issues.apache.org/jira/browse/HADOOP-8375
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8375.txt, HADOOP-8375.txt
>
>
> It does not makes sense to run findbugs or javadoc check if the program does not compile. It was the behavior previously if I remember correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira