You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/06/07 16:10:01 UTC

[GitHub] storm issue #2153: [STORM-2544] Fixing issue in acking of tuples that hit re...

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2153
  
    This LGTM. I'm wondering if you would be up for adding a unit test of this as well? (e.g. set up a spout with a RetryService that allows no retries, fail a tuple then verify that it gets committed. See KafkaSpoutEmitTest for an example of unit testing the spout)
    
    If not that's fine too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---