[GitHub] sijie commented on a change in pull request #521: Issue 520: Add more http endpoint

[gi...@git.apache.org]

sijie commented on a change in pull request #521: Issue 520: Add more http endpoint
URL: https://github.com/apache/bookkeeper/pull/521#discussion_r142213079
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/http/BKHttpServiceProvider.java
 ##########
 @@ -0,0 +1,304 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+package org.apache.bookkeeper.http;
+
+import org.apache.bookkeeper.bookie.Bookie;
+import org.apache.bookkeeper.conf.ServerConfiguration;
+import org.apache.bookkeeper.http.service.ErrorHttpService;
+import org.apache.bookkeeper.http.service.HeartbeatService;
+import org.apache.bookkeeper.http.service.HttpEndpointService;
+import org.apache.bookkeeper.proto.BookieServer;
+import org.apache.bookkeeper.replication.Auditor;
+import org.apache.bookkeeper.replication.AutoRecoveryMain;
+
+/**
+ * Bookkeeper based implementation of HttpServiceProvider,
+ * which provide bookkeeper services to handle http requests
+ * from different http endpoints.
+ */
+public class BKHttpServiceProvider implements HttpServiceProvider {
+
+    private final BookieServer bookieServer;
+    private final AutoRecoveryMain autoRecovery;
+    private final ServerConfiguration serverConf;
+
+    private BKHttpServiceProvider(BookieServer bookieServer,
+                                  AutoRecoveryMain autoRecovery,
+                                  ServerConfiguration serverConf) {
+        this.bookieServer = bookieServer;
+        this.autoRecovery = autoRecovery;
+        this.serverConf = serverConf;
+    }
+
+    private ServerConfiguration getServerConf() {
+        return serverConf;
+    }
+
+    private Auditor getAuditor() {
+        return autoRecovery == null ? null : autoRecovery.getAuditor();
+    }
+
+    private Bookie getBookie() {
+        return bookieServer == null ? null : bookieServer.getBookie();
+    }
+
+    /**
+     * Builder for HttpServiceProvider.
+     */
+    public static class Builder {
+
+        BookieServer bookieServer = null;
+        AutoRecoveryMain autoRecovery = null;
+        ServerConfiguration serverConf = null;
+
+        public Builder setBookieServer(BookieServer bookieServer) {
+            this.bookieServer = bookieServer;
+            return this;
+        }
+
+        public Builder setAutoRecovery(AutoRecoveryMain autoRecovery) {
+            this.autoRecovery = autoRecovery;
+            return this;
+        }
+
+        public Builder setServerConfiguration(ServerConfiguration conf) {
+            this.serverConf = conf;
+            return this;
+        }
+
+        public BKHttpServiceProvider build() {
+            return new BKHttpServiceProvider(
+                bookieServer,
+                autoRecovery,
+                serverConf
+            );
+        }
+    }
+
+    @Override
+    public HttpEndpointService provideHeartbeatService() {
+        return new HeartbeatService();
+    }
+
+    @Override
+    public HttpEndpointService provideConfigurationService() {
+        ServerConfiguration configuration = getServerConf();
+        if (configuration == null) {
+            return new ErrorHttpService();
+        }
+        return new ConfigurationService(configuration);
+    }
+
+    // TODO
 
 Review comment:
   remove this?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services