You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/12 06:57:14 UTC
[GitHub] becketqin commented on a change in pull request #7679:
[FLINK-11501][Kafka Connector] Add ratelimiting to Kafka consumer
becketqin commented on a change in pull request #7679: [FLINK-11501][Kafka Connector] Add ratelimiting to Kafka consumer
URL: https://github.com/apache/flink/pull/7679#discussion_r255776176
##########
File path: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer010.java
##########
@@ -69,6 +70,10 @@
private static final long serialVersionUID = 2324564345203409112L;
+ /** Configuration to set consumer prefix for ratelimiting. **/
+ private static final String CONSUMER_PREFIX = "kafka";
Review comment:
Do we need this prefix? Can all the source and sink share the same configuration name？ If we do need the prefix, can we put this in somewhere like `FlinkKafkaConsumerBase`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services