You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Navina Ramesh <nr...@linkedin.com> on 2016/03/16 23:21:43 UTC
Review Request 44935: SAMZA-898 - TestSamzaTaskManager incorrectly
shares
mock state across tests that cause failures when test ordering changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44935/
-----------------------------------------------------------
Review request for samza, Boris Shkolnik, Jake Maes, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Repository: samza
Description
-------
SAMZA-898 - TestSamzaTaskManager incorrectly shares mock state across tests that cause failures when test ordering changes
Diffs
-----
samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 6ff9aaceb7107692b5233c675af9cccabc832044
samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskManager.java 9da1edf6ff165ef0306de8730853ad30551a9831
Diff: https://reviews.apache.org/r/44935/diff/
Testing
-------
Tests (unrelated ones) failed as trunk is unstable currently. Will fix it and try again.
Thanks,
Navina Ramesh
Re: Review Request 44935: SAMZA-898 - TestSamzaTaskManager incorrectly
shares mock state across tests that cause failures when test ordering changes
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44935/#review125808
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On March 16, 2016, 10:21 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44935/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 10:21 p.m.)
>
>
> Review request for samza, Boris Shkolnik, Jake Maes, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-898 - TestSamzaTaskManager incorrectly shares mock state across tests that cause failures when test ordering changes
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 6ff9aaceb7107692b5233c675af9cccabc832044
> samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskManager.java 9da1edf6ff165ef0306de8730853ad30551a9831
>
> Diff: https://reviews.apache.org/r/44935/diff/
>
>
> Testing
> -------
>
> Tests (unrelated ones) failed as trunk is unstable currently. Will fix it and try again.
>
>
> Thanks,
>
> Navina Ramesh
>
>