You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/01/12 03:47:05 UTC

[GitHub] zeppelin pull request #2725: ZPEPELIN-3136. IPython Code Completion Improvem...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2725

    ZPEPELIN-3136. IPython Code Completion Improvement

    ### What is this PR for?
    
    This is for better code completion support for IPythonInterpreter
    
    
    ### What type of PR is it?
    [Improvement ]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3136
    
    ### How should this be tested?
    * Unit test is updated and Manually verified. 
    
    ### Screenshots (if appropriate)
    ![code_completion](https://user-images.githubusercontent.com/164491/34858941-3f28105a-f78e-11e7-8341-2fbfd306ba5b.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3136

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2725
    
----
commit 1179fc82563b6b5c5251b2c288cb094a4a94bc8f
Author: Jeff Zhang <zj...@...>
Date:   2018-01-12T03:45:16Z

    ZPEPELIN-3136. IPython Code Completion Improvement

----


---

[GitHub] zeppelin issue #2725: ZEPPELIN-3136. IPython Code Completion Improvement

Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/2725
  
    I have tested.
    It's very useful bug fix.
    @zjffdu thank you!


---

[GitHub] zeppelin issue #2725: ZEPPELIN-3136. IPython Code Completion Improvement

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2725
  
    Tried it on local, works well.


---

[GitHub] zeppelin pull request #2725: ZEPPELIN-3136. IPython Code Completion Improvem...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2725


---

[GitHub] zeppelin issue #2725: ZEPPELIN-3136. IPython Code Completion Improvement

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2725
  
    @prabhjyotsingh @felixcheung Mind to help review it ?


---

[GitHub] zeppelin issue #2725: ZEPPELIN-3136. IPython Code Completion Improvement

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2725
  
    Thanks @mebelousov for testing it. 


---