You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/08 12:55:06 UTC
[GitHub] [dubbo] EarthChen commented on a change in pull request #8730: rename rpc h2 settings key
EarthChen commented on a change in pull request #8730:
URL: https://github.com/apache/dubbo/pull/8730#discussion_r704389618
##########
File path: dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/Constants.java
##########
@@ -95,10 +95,10 @@
String INVOCATION_KEY = "invocation";
String SERIALIZATION_ID_KEY = "serialization_id";
- String H2_SETTINGS_HEADER_TABLE_SIZE_KEY = "h2.settings.header-table-size";
- String H2_SETTINGS_ENABLE_PUSH_KEY = "h2.settings.enable-push";
- String H2_SETTINGS_MAX_CONCURRENT_STREAMS_KEY = "h2.settings.max-concurrent-streams";
- String H2_SETTINGS_INITIAL_WINDOW_SIZE_KEY = "h2.settings.initial-window-size";
- String H2_SETTINGS_MAX_FRAME_SIZE_KEY = "h2.settings.max-frame-size";
- String H2_SETTINGS_MAX_HEADER_LIST_SIZE_KEY = "h2.settings.max-header-list-size";
+ String H2_SETTINGS_HEADER_TABLE_SIZE_KEY = "dubbo.rpc.tri.header-table-size";
+ String H2_SETTINGS_ENABLE_PUSH_KEY = "dubbo.rpc.tri.enable-push";
+ String H2_SETTINGS_MAX_CONCURRENT_STREAMS_KEY = "dubbo.rpc.tri.max-concurrent-streams";
+ String H2_SETTINGS_INITIAL_WINDOW_SIZE_KEY = "dubbo.rpc.tri.init-window-size";
Review comment:
It's better to just change the prefix . `dubbo.rpc.tri.initial-window-size`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org