[jira] [Commented] (HBASE-14861) HBASE_ZNODE_FILE on master server is overwritten by regionserver process in case of master-rs collocation

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024496#comment-15024496 ] 

Hadoop QA commented on HBASE-14861:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12774028/HBASE-14861.patch
  against master branch at commit 0bae444b34b6be3a28b5ccc036afb5add23818c6.
  ATTACHMENT ID: 12774028

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 18692 checkstyle errors (more than the master's current 18686 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16650//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16650//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16650//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16650//console

This message is automatically generated.

> HBASE_ZNODE_FILE on master server is overwritten by regionserver process in case of master-rs collocation 
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14861
>                 URL: https://issues.apache.org/jira/browse/HBASE-14861
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>    Affects Versions: 2.0.0
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14861.patch
>
>
> In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by regionserver process in HRegionServer#handleReportForDutyResponse() here is how it looks on master server:
> {code}
> [hbase@hnode2 hbase]$ cat hbase-hbase-master.znode 
> /hbase/rs/hnode2,16000,1448022074888
> {code}
> it contains regionserver znode path instead of String value of master's ServerName.  This affects ZNodeClearer#clear() in way that will not clear master znode in case we detect master crash. At end this will extend  failover time until master znode expires configured in zookeeper by maxSessionTimeout parameter (40s in my case).
> I have notice this on mater branch but it can be case in other branches where we are collocating master and rs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)