[GitHub] [pulsar] codelipenghui commented on a change in pull request #14655: Support delete schema forcefully

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #14655:
URL: https://github.com/apache/pulsar/pull/14655#discussion_r826497736



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Schemas.java
##########
@@ -98,6 +98,22 @@
      */
     CompletableFuture<Void> deleteSchemaAsync(String topic);
 
+    /**
+     * Delete the schema associated with a given <tt>topic</tt>.
+     *
+     * @param topic topic name, in fully qualified format
+     * @param force force to delete schema

Review comment:
       ```suggestion
        * @param force to delete schema
   ```
   
   And it's better to provide more information about what is the difference after use force==true, it looks like if force==false, which means it's a mark deletion operation, will not remove any resources, but with force==true, it will remove all the resources used by schema.

##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
##########
@@ -78,10 +78,14 @@ void run() throws Exception {
         @Parameter(description = "persistent://tenant/namespace/topic", required = true)
         private java.util.List<String> params;
 
+        @Parameter(names = { "-f",
+                "--force" }, description = "Delete schema forcefully")

Review comment:
       Same as the above comment, it's better to provide more information to understand what is the difference after use `--force`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org