You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2011/05/26 17:57:43 UTC
svn commit: r1127977 -
/lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/codecs/intblock/VariableIntBlockIndexOutput.java
Author: mikemccand
Date: Thu May 26 15:57:43 2011
New Revision: 1127977
URL: http://svn.apache.org/viewvc?rev=1127977&view=rev
Log:
LUCENE-3148: if VarIntBlockIO hits exc during write, don't stuff 0s during close
Modified:
lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/codecs/intblock/VariableIntBlockIndexOutput.java
Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/codecs/intblock/VariableIntBlockIndexOutput.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/codecs/intblock/VariableIntBlockIndexOutput.java?rev=1127977&r1=1127976&r2=1127977&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/codecs/intblock/VariableIntBlockIndexOutput.java (original)
+++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/codecs/intblock/VariableIntBlockIndexOutput.java Thu May 26 15:57:43 2011
@@ -41,6 +41,7 @@ public abstract class VariableIntBlockIn
protected final IndexOutput out;
private int upto;
+ private boolean hitExcDuringWrite;
// TODO what Var-Var codecs exist in practice... and what are there blocksizes like?
// if its less than 128 we should set that as max and use byte?
@@ -105,19 +106,23 @@ public abstract class VariableIntBlockIn
@Override
public void write(int v) throws IOException {
+ hitExcDuringWrite = true;
upto -= add(v)-1;
+ hitExcDuringWrite = false;
assert upto >= 0;
}
@Override
public void close() throws IOException {
try {
- // stuff 0s in until the "real" data is flushed:
- int stuffed = 0;
- while(upto > stuffed) {
- upto -= add(0)-1;
- assert upto >= 0;
- stuffed += 1;
+ if (!hitExcDuringWrite) {
+ // stuff 0s in until the "real" data is flushed:
+ int stuffed = 0;
+ while(upto > stuffed) {
+ upto -= add(0)-1;
+ assert upto >= 0;
+ stuffed += 1;
+ }
}
} finally {
out.close();