You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/07 15:30:07 UTC

[GitHub] [nifi-registry] thenatog opened a new pull request #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…

thenatog opened a new pull request #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…
URL: https://github.com/apache/nifi-registry/pull/273
 
 
   …ill send the Jetty server version in responses.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-registry] alopresto commented on issue #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…

Posted by GitBox <gi...@apache.org>.
alopresto commented on issue #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…
URL: https://github.com/apache/nifi-registry/pull/273#issuecomment-610562834
 
 
   Reviewing...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-registry] asfgit closed pull request #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…
URL: https://github.com/apache/nifi-registry/pull/273
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi-registry] alopresto commented on issue #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…

Posted by GitBox <gi...@apache.org>.
alopresto commented on issue #273: NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…
URL: https://github.com/apache/nifi-registry/pull/273#issuecomment-610757135
 
 
   The behavior looks good to me. I am going to add the new property to the default `nifi-registry.properties` file with a default value of `true` and then merge. 
   
   _Before setting `nifi.registry.web.should.send.server.version=false` in `nifi-registry.properties`:_
   ```
   curl http://127.0.0.1:18080/nifi-registry -vvv                                                                                                                      22:15:55
   *   Trying 127.0.0.1...
   * TCP_NODELAY set
   * Connected to 127.0.0.1 (127.0.0.1) port 18080 (#0)
   > GET /nifi-registry HTTP/1.1
   > Host: 127.0.0.1:18080
   > User-Agent: curl/7.64.1
   > Accept: */*
   >
   < HTTP/1.1 302 Found
   < Date: Wed, 08 Apr 2020 05:15:59 GMT
   < Location: http://127.0.0.1:18080/nifi-registry/
   < Content-Length: 0
   < Server: Jetty(9.4.19.v20190610)
   <
   * Connection #0 to host 127.0.0.1 left intact
   * Closing connection 0
   ```
   
   _After setting `nifi.registry.web.should.send.server.version=false` in `nifi-registry.properties`:_
   ```
   curl http://127.0.0.1:18080/nifi-registry -vvv                                                                                                                  22:17:33
   *   Trying 127.0.0.1...
   * TCP_NODELAY set
   * Connected to 127.0.0.1 (127.0.0.1) port 18080 (#0)
   > GET /nifi-registry HTTP/1.1
   > Host: 127.0.0.1:18080
   > User-Agent: curl/7.64.1
   > Accept: */*
   >
   < HTTP/1.1 302 Found
   < Date: Wed, 08 Apr 2020 05:17:36 GMT
   < Location: http://127.0.0.1:18080/nifi-registry/
   < Content-Length: 0
   <
   * Connection #0 to host 127.0.0.1 left intact
   * Closing connection 0
   ```
   
   The 404 page does not reveal the server version either. 
   ![image](https://user-images.githubusercontent.com/798465/78747319-fcc4f480-791d-11ea-8af3-8911dadab99f.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services