You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by Michael Osipov <mi...@apache.org> on 2024/02/10 19:42:03 UTC
[VOTE] Release Velocity Tools version 3.2
Hi,
IMPORTANT: This requires the following staging repo:
https://repository.apache.org/content/repositories/orgapachevelocity-1041/
Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310130&version=12351146
Staging repo:
https://repository.apache.org/content/repositories/orgapachevelocity-1042/
https://repository.apache.org/content/repositories/orgapachevelocity-1042/org/apache/velocity/tools/velocity-tools-parent/3.2/velocity-tools-parent-3.2-source-release.zip
Source release checksum(s):
velocity-tools-parent-3.2-source-release
sha512:
6fb10aa15a43e820b3d7bf398e09ebdc2be854253d004b8962108fb4f311e4d5dd952ebfe04e22365c04334be3578c0ef12fcc18f37efd918bf0a6faaa213435
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Michael Osipov <mi...@apache.org>.
Am 2024-02-10 um 20:42 schrieb Michael Osipov:
> Hi,
>
> IMPORTANT: This requires the following staging repo:
> https://repository.apache.org/content/repositories/orgapachevelocity-1041/
>
> Release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310130&version=12351146
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachevelocity-1042/
> https://repository.apache.org/content/repositories/orgapachevelocity-1042/org/apache/velocity/tools/velocity-tools-parent/3.2/velocity-tools-parent-3.2-source-release.zip
>
> Source release checksum(s):
> velocity-tools-parent-3.2-source-release
> sha512:
> 6fb10aa15a43e820b3d7bf398e09ebdc2be854253d004b8962108fb4f311e4d5dd952ebfe04e22365c04334be3578c0ef12fcc18f37efd918bf0a6faaa213435
>
> Vote open for 72 hours.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Nathan Bubna <nb...@gmail.com>.
+1
On Sat, Feb 10, 2024 at 11:42 AM Michael Osipov <mi...@apache.org> wrote:
> Hi,
>
> IMPORTANT: This requires the following staging repo:
> https://repository.apache.org/content/repositories/orgapachevelocity-1041/
>
> Release notes:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310130&version=12351146
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapachevelocity-1042/
>
> https://repository.apache.org/content/repositories/orgapachevelocity-1042/org/apache/velocity/tools/velocity-tools-parent/3.2/velocity-tools-parent-3.2-source-release.zip
>
> Source release checksum(s):
> velocity-tools-parent-3.2-source-release
> sha512:
>
> 6fb10aa15a43e820b3d7bf398e09ebdc2be854253d004b8962108fb4f311e4d5dd952ebfe04e22365c04334be3578c0ef12fcc18f37efd918bf0a6faaa213435
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
>
[CANCEL] [VOTE] Release Velocity Tools version 3.2
Posted by Michael Osipov <mi...@apache.org>.
Canceling the vote and dropping the release. It did not reach the
required quorum.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
About the tools, I think we should drop the jsp module. Nobody is
maintaining it.
On 14/02/2024 10:26, Claude Brisson wrote:
> Yes, thanks :-)
>
> On 13/02/2024 20:00, Michael Osipov wrote:
>> On 2024/02/13 17:39:38 Claude Brisson wrote:
>>> Maybe it's nitpicking, but having the users being able to build without
>>> errors is a precaution which is worth repackaging an engine RC, since
>>> we're at it... no?
>> I don't consider this as nitpicking, but you need to consider the
>> failure reason as well. The actual code works as intended. Your
>> points are valid.
>> Do you want me to drop, remove the test and re-roll the release?
>>
>> M
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
>> For additional commands, e-mail: dev-help@velocity.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
Yes, thanks :-)
On 13/02/2024 20:00, Michael Osipov wrote:
> On 2024/02/13 17:39:38 Claude Brisson wrote:
>> Maybe it's nitpicking, but having the users being able to build without
>> errors is a precaution which is worth repackaging an engine RC, since
>> we're at it... no?
> I don't consider this as nitpicking, but you need to consider the failure reason as well. The actual code works as intended. Your points are valid.
> Do you want me to drop, remove the test and re-roll the release?
>
> M
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/13 17:39:38 Claude Brisson wrote:
> Maybe it's nitpicking, but having the users being able to build without
> errors is a precaution which is worth repackaging an engine RC, since
> we're at it... no?
I don't consider this as nitpicking, but you need to consider the failure reason as well. The actual code works as intended. Your points are valid.
Do you want me to drop, remove the test and re-roll the release?
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
Maybe it's nitpicking, but having the users being able to build without
errors is a precaution which is worth repackaging an engine RC, since
we're at it... no?
On 13/02/2024 18:09, Michael Osipov wrote:
> On 2024/02/13 15:25:42 Claude Brisson wrote:
>> Since I could not build the engine RC, I cannot test the tools RC
>> without tweaking the poms.
> As a followup to your comments I found another issue for tests: https://github.com/apache/velocity-tools/pull/17
>
> Though, it is not a blocker because it does not affect runtime behavior, just testing.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/13 15:25:42 Claude Brisson wrote:
> Since I could not build the engine RC, I cannot test the tools RC
> without tweaking the poms.
As a followup to your comments I found another issue for tests: https://github.com/apache/velocity-tools/pull/17
Though, it is not a blocker because it does not affect runtime behavior, just testing.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Claude Brisson <cl...@renegat.net.INVALID>.
Since I could not build the engine RC, I cannot test the tools RC
without tweaking the poms.
Usually, I first release the engine then the tools.
Also, I think it is a good practice to name RC tags 2.4-rc1, etc. and to
only tag the release with 2.4.
Best,
Claude
On 13/02/2024 14:35, Michael Osipov wrote:
> Guys, last day for votes. Please have a look.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Posted by Michael Osipov <mi...@apache.org>.
Guys, last day for votes. Please have a look.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org