You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/22 11:00:42 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #4267: Present project view files as tree leaves.
sdedic opened a new pull request, #4267:
URL: https://github.com/apache/netbeans/pull/4267
The current `foundProjects` tree view exported from LSP presents certain files as expandable, although they are not - most notably XML files. This is different from NB IDE environment - in NB IDE, the XML file is handled by `org.netbeans.modules.xml` and its XMLDataObject, which behaves fine. But in the reduced NBLS environment, XML files are handled by `openide.loaders` module and its base XMLDataObject that attempts to delegate its node to several implementations. This delegation breaks `isLeaf()` detection in `Node` interface - the loader's XML node may eventually get some children, when it rebounds to a node with children, so it is not a leaf according to NetBeans APIs.
There are other nodes, like Bundle.properties that also show subnodes in the Projects view, this time in NetBeans IDE as well. But for the LSP project navigation I believe that exposing internal structure right in the Project tree is not good.
I've added a decorator to the project view, that will force `CollapsibleState = None` for `TreeItems` that correspond to a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #4267: Present project view files as tree leaves.
Posted by GitBox <gi...@apache.org>.
sdedic merged PR #4267:
URL: https://github.com/apache/netbeans/pull/4267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4267: Present project view files as tree leaves.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4267:
URL: https://github.com/apache/netbeans/pull/4267#issuecomment-1169925040
The sigtest failures were fixed by #4258; merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists