[jira] [Commented] (CONNECTORS-1615) Bad Error Message when IDCOLUMN's value is actually null

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CONNECTORS-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897066#comment-16897066 ] 

Karl Wright commented on CONNECTORS-1615:
-----------------------------------------

Your query should never return rows that have null IDs.  ManifoldCF cannot work with documents that don't have an ID.

As for the error message being incorrect -- if you accept that null IDs are not allowed, then the error message is perfectly fine.  There is no good way to disambiguate a null from a null that is common across all JDBC drivers we support.


> Bad Error Message when IDCOLUMN's value is actually null
> --------------------------------------------------------
>
>                 Key: CONNECTORS-1615
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1615
>             Project: ManifoldCF
>          Issue Type: Bug
>          Components: JDBC connector
>    Affects Versions: ManifoldCF 2.13
>            Reporter: Michael Cizmar
>            Priority: Major
>
> In the edge case that the id column is null, the error message doesn't suggest that.
>  
> {code:java}
> Object o = row.getValue(JDBCConstants.idReturnColumnName);
> 	if (o == null)
> 	throw new ManifoldCFException("Bad seed query; doesn't return $(IDCOLUMN) column. Try using quotes around $(IDCOLUMN) variable, e.g. \"$(IDCOLUMN)\", or, for MySQL, select \"by label\" in your repository connection.");
> 	String idValue = JDBCConnection.readAsString(o);
> {code}
>  
>  
> Also, should it entirely fail if one $IDCOLUMN record is null?



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)