You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by br...@apache.org on 2009/01/29 03:43:20 UTC
svn commit: r738722 - in
/maven/core-integration-testing/trunk/core-it-suite/src/test:
java/org/apache/maven/it/MavenITmng3810BadProfileActivationTest.java
resources/mng-3810/ resources/mng-3810/property/
resources/mng-3810/property/pom.xml
Author: brett
Date: Thu Jan 29 02:43:19 2009
New Revision: 738722
URL: http://svn.apache.org/viewvc?rev=738722&view=rev
Log:
[MNG-3810] integration test for poorly constructed profiles improved error handling (could be expanded for more cases in future)
Added:
maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3810BadProfileActivationTest.java (with props)
maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/
maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/property/
maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/property/pom.xml (with props)
Added: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3810BadProfileActivationTest.java
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3810BadProfileActivationTest.java?rev=738722&view=auto
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3810BadProfileActivationTest.java (added)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3810BadProfileActivationTest.java Thu Jan 29 02:43:19 2009
@@ -0,0 +1,66 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.util.Properties;
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-3810">MNG-3810</a>.
+ *
+ * @author Brett Porter
+ * @version $Id: MavenITmng2605BogusProfileActivationTest.java 734813 2009-01-15 20:41:59Z bentmann $
+ */
+public class MavenITmng3810BadProfileActivationTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ public MavenITmng3810BadProfileActivationTest()
+ {
+ super( "(2.0.10,2.1.0-M1),(2.1.0-M1,3.0-alpha-1),(3.0-alpha-1,)" ); // 2.0.10+, 2.1.0-M2+, 3.0-alpha-2+
+ }
+
+ public void testitMNG3810Property()
+ throws Exception
+ {
+ File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-3810/property" );
+
+ Verifier verifier = new Verifier( testDir.getAbsolutePath() );
+ verifier.setAutoclean( false );
+ verifier.deleteDirectory( "target" );
+ try
+ {
+ verifier.executeGoal( "validate" );
+ fail( "Build should not succeed" );
+ }
+ catch ( Exception e )
+ {
+ verifier.verifyTextInLog( "The property name is required to activate the profile" );
+ }
+ verifier.resetStreams();
+
+ Properties props = verifier.loadProperties( "target/profile.properties" );
+ assertNull( props.getProperty( "project.properties.pomProperty" ) );
+ }
+
+}
Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3810BadProfileActivationTest.java
------------------------------------------------------------------------------
svn:eol-style = native
Added: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/property/pom.xml
URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/property/pom.xml?rev=738722&view=auto
==============================================================================
--- maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/property/pom.xml (added)
+++ maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/property/pom.xml Thu Jan 29 02:43:19 2009
@@ -0,0 +1,70 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.its.mng3810</groupId>
+ <artifactId>property</artifactId>
+ <version>0.1</version>
+
+ <name>Maven Integration Test :: MNG-3810</name>
+ <description>
+ Test profiles that are malformed in the POM get a decent error message.
+ </description>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.its.plugins</groupId>
+ <artifactId>maven-it-plugin-expression</artifactId>
+ <version>2.1-SNAPSHOT</version>
+ <executions>
+ <execution>
+ <phase>validate</phase>
+ <goals>
+ <goal>eval</goal>
+ </goals>
+ <configuration>
+ <outputFile>target/profile.properties</outputFile>
+ <expressions>
+ <expression>project/properties</expression>
+ </expressions>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>mng-3810-pom</id>
+ <activation>
+ <property>
+ </property>
+ </activation>
+ <properties>
+ <pomProperty>INJECTED</pomProperty>
+ </properties>
+ </profile>
+ </profiles>
+</project>
Propchange: maven/core-integration-testing/trunk/core-it-suite/src/test/resources/mng-3810/property/pom.xml
------------------------------------------------------------------------------
svn:eol-style = native