[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18529: Revert "[improve][broker] Unreasonable AuthenticationException refere…

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #18529:
URL: https://github.com/apache/pulsar/pull/18529#discussion_r1027047030


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java:
##########
@@ -107,6 +108,8 @@ public String authenticateHttpRequest(HttpServletRequest request, Authentication
                     LOG.debug("Authentication failed for provider " + providerToUse.getAuthMethodName() + " : "
                             + e.getMessage(), e);
                 }
+                // Store the exception so we can throw it later instead of a generic one
+                authenticationException = e;
                 throw e;

Review Comment:
   Thanks for your review @BewareMyPower. I misread the original code. We can close this now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org