You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "Linchen-Xu (via GitHub)" <gi...@apache.org> on 2023/11/08 05:51:12 UTC

[PR] optimize JVMUtil [dubbo]

Linchen-Xu opened a new pull request, #13334:
URL: https://github.com/apache/dubbo/pull/13334

   ## What is the purpose of the change
   fix #13327 
   - `dubbo.jstack-dump.max-line` can be used to indicate that all stack trace lines should be printed now by setting it to a negative number, -1 for example.
   - write stack trace info directly into OutputStream instead of building a String
   
   ## Brief changelog
   update org.apache.dubbo.common.utils.JVMUtil
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

Re: [PR] feat: fix #13327 [dubbo]

Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.

AlbumenJ commented on code in PR #13334:
URL: https://github.com/apache/dubbo/pull/13334#discussion_r1386243505


##########
dubbo-common/src/main/java/org/apache/dubbo/common/utils/JVMUtil.java:
##########
@@ -33,75 +33,84 @@ public class JVMUtil {
     public static void jstack(OutputStream stream) throws Exception {
         ThreadMXBean threadMxBean = ManagementFactory.getThreadMXBean();
         for (ThreadInfo threadInfo : threadMxBean.dumpAllThreads(true, true)) {
-            stream.write(getThreadDumpString(threadInfo).getBytes());
+            getThreadDumpString(stream, threadInfo);
         }
     }
 
-    private static String getThreadDumpString(ThreadInfo threadInfo) {
-        StringBuilder sb = new StringBuilder("\"" + threadInfo.getThreadName() + "\"" + " Id="
-                + threadInfo.getThreadId() + " " + threadInfo.getThreadState());
+    private static void getThreadDumpString(final OutputStream stream, ThreadInfo threadInfo) throws Exception {
+        // print basic info
+        stream.write(String.format(
+                        "\"%s\" Id=%d %s",
+                        threadInfo.getThreadName(), threadInfo.getThreadId(), threadInfo.getThreadState())
+                .getBytes());
         if (threadInfo.getLockName() != null) {
-            sb.append(" on " + threadInfo.getLockName());
+            stream.write(String.format(" on %s", threadInfo.getLockName()).getBytes());
         }
         if (threadInfo.getLockOwnerName() != null) {
-            sb.append(" owned by \"" + threadInfo.getLockOwnerName() + "\" Id=" + threadInfo.getLockOwnerId());
+            stream.write(
+                    String.format(" owned by \"%s\" Id=%d", threadInfo.getLockOwnerName(), threadInfo.getLockOwnerId())
+                            .getBytes());
         }
         if (threadInfo.isSuspended()) {
-            sb.append(" (suspended)");
+            stream.write(" (suspended)".getBytes());
         }
         if (threadInfo.isInNative()) {
-            sb.append(" (in native)");
+            stream.write(" (in native)".getBytes());
         }
-        sb.append('\n');
-        int i = 0;
+        stream.write("\n".getBytes());
+
+        // calculate stack print depth
+        StackTraceElement[] stackTrace = threadInfo.getStackTrace();
         // default is 32, means only print up to 32 lines
-        int jstackMaxLine = 32;
+        int printStackDepth = Math.min(32, stackTrace.length);
         String jstackMaxLineStr = System.getProperty(CommonConstants.DUBBO_JSTACK_MAXLINE);
         if (StringUtils.isNotEmpty(jstackMaxLineStr)) {
             try {
-                jstackMaxLine = Integer.parseInt(jstackMaxLineStr);
+                printStackDepth = Integer.parseInt(jstackMaxLineStr);

Review Comment:
   Seems should be `Math.min(stackTrace.length, Integer.parseInt(jstackMaxLineStr))`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

Re: [PR] feat: fix #13327 [dubbo]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #13334:
URL: https://github.com/apache/dubbo/pull/13334#issuecomment-1801188262

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#13334](https://app.codecov.io/gh/apache/dubbo/pull/13334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3d493ce) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/9cb36bc2ed7e23ca2883ace2f7acf4d532e95486?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9cb36bc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.2   #13334      +/-   ##
   ============================================
   - Coverage     69.57%   69.56%   -0.01%     
     Complexity        2        2              
   ============================================
     Files          1652     1652              
     Lines         71608    71608              
     Branches      10264    10265       +1     
   ============================================
   - Hits          49821    49817       -4     
   + Misses        17099    17097       -2     
   - Partials       4688     4694       +6     
   ```
   
   
   [see 35 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/13334/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org