You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/03 18:10:01 UTC
[GitHub] [superset] eschutho opened a new pull request #12921: rename duplicate build jobs
eschutho opened a new pull request #12921:
URL: https://github.com/apache/superset/pull/12921
### SUMMARY
On https://github.com/apache/superset/pull/12694 we started moving some required checks to the new .asf.yaml config that Apache provides. We started by testing just one job so that we could verify that it worked and we didn't inadvertently block any jobs by using the wrong job name. We have tested that the file is working, but there are some checks with duplicate names. This pr adds a few more checks in and renames the duplicate jobs. In one more PR, I will add the rest of the checks with the new job names.
### TEST PLAN
Verify that master requires the new jobs when this merges.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12921: rename duplicate build jobs
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12921:
URL: https://github.com/apache/superset/pull/12921#discussion_r569648624
##########
File path: .asf.yaml
##########
@@ -61,6 +61,8 @@ github:
# contexts are the names of checks that must pass
contexts:
- check
+ - lint
+ - test-mysql
Review comment:
I think we may need to append python version to `test-mysql` as well. E.g. `test-mysql (3.7)`.
It seems GitHub checks uses the job name with matrix variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #12921: chore: rename duplicate build jobs
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12921:
URL: https://github.com/apache/superset/pull/12921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #12921: rename duplicate build jobs
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #12921:
URL: https://github.com/apache/superset/pull/12921#issuecomment-772745756
@ktmud feel free to merge when ready if this looks good to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #12921: rename duplicate build jobs
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #12921:
URL: https://github.com/apache/superset/pull/12921#discussion_r569667486
##########
File path: .asf.yaml
##########
@@ -61,6 +61,8 @@ github:
# contexts are the names of checks that must pass
contexts:
- check
+ - lint
+ - test-mysql
Review comment:
ok, good call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #12921: rename duplicate build jobs
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #12921:
URL: https://github.com/apache/superset/pull/12921#issuecomment-772714631
@nytai @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org