You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/17 01:40:21 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3470: [Enhancement] Make this method "synchronized" to match the parent class implementation.[ EventMeshMessageTCPSubClient]
Alonexc opened a new issue, #3470:
URL: https://github.com/apache/incubator-eventmesh/issues/3470
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java line 71
analysis and explanation:
When @Overrides of synchronized methods are not themselves synchronized, the result can be improper synchronization as callers rely on the thread-safety promised by the parent class.
### Describe the solution you'd like
add "synchronized" to the method.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc closed issue #3470: [Enhancement] Make this method "synchronized" to match the parent class implementation.[EventMeshMessageTCPSubClient]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc closed issue #3470: [Enhancement] Make this method "synchronized" to match the parent class implementation.[EventMeshMessageTCPSubClient]
URL: https://github.com/apache/eventmesh/issues/3470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on issue #3470: [Enhancement] Make this method "synchronized" to match the parent class implementation.[EventMeshMessageTCPSubClient]
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on issue #3470:
URL: https://github.com/apache/eventmesh/issues/3470#issuecomment-1518007900
https://github.com/apache/eventmesh/blob/7d3bbde05289982d19ab39ff1a8f1c55a382e5d5/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java#L71-L87
I‘m not sure this is a issue. Although `EventMeshMessageTCPSubClient#reconnect()` has no `synchronized`, it has `synchronized` in the method body. `super.reconnect()` has `synchronized`, too. The logic of `hello()` involves only one global variable `contexts` and it is CHM. The logic of `listen()` is similar to `hello()`. It seems that there is no need to add `synchronized`.
Is there any problem with my analysis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on issue #3470: [Enhancement] Make this method "synchronized" to match the parent class implementation.[EventMeshMessageTCPSubClient]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3470:
URL: https://github.com/apache/eventmesh/issues/3470#issuecomment-1518907367
It is indeed unnecessary and I will close the relevant issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org