You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/22 11:16:45 UTC

[GitHub] [pulsar-client-go] jonyhy96 opened a new pull request #471: [Issue 444][fix] Use newError to build return error

jonyhy96 opened a new pull request #471:
URL: https://github.com/apache/pulsar-client-go/pull/471


   Fixes #444
   
   ### Motivation
   
   For better error assertion in client side.
   
   ### Modifications
   
   Fix newError and use newError to build return error in most case.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API:  no
     - The schema:  no
     - The default values of configurations:  no
     - The wire protocol: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? GoDocs 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy merged pull request #471: [Issue 444][fix] Use newError to build return error

Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #471:
URL: https://github.com/apache/pulsar-client-go/pull/471


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] jonyhy96 commented on pull request #471: [Issue 444][fix] Use newError to build return error

Posted by GitBox <gi...@apache.org>.
jonyhy96 commented on pull request #471:
URL: https://github.com/apache/pulsar-client-go/pull/471#issuecomment-783300728


   /cc @freeznet 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org