You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/02 17:32:31 UTC
[GitHub] [pulsar] bytestreme opened a new pull request #11201: [docs] Fix 'Community' dropdown menu symbols
bytestreme opened a new pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
In the navigation bar of the docs 'Community' dropdown menu has some symbols displayed incorrectly (❐), and has an empty item in the list
### Modifications
Removed the symbols and the empty list item as well
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bytestreme edited a comment on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
bytestreme edited a comment on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-873443239
@Anonymitaet @michaeljmarshall please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-903373632
Hi @bytestreme we're redesigning the website and may have a new design for the drop-down list, so could you please revert your changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-873725640
New changes LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bytestreme commented on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
bytestreme commented on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-873443239
@feynmanlin @Anonymitaet @michaeljmarshall please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-874448954
@tuteng does "show external or internal links" matter?
Just my two cents: generally users do not care whether it is an external or internal link. Besides, the space of the drop-down menus on the breadcrumb navigation is limited, removing unnecessary icons might be a better way to make the layout looks more organized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-873725504
@tuteng could you please help review this PR from the technical perspective? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bytestreme commented on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
bytestreme commented on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-906520830
> Hi @bytestreme we're redesigning the website and may have a new design for the drop-down list, so how about reverting your changes?
Hello, @Anonymitaet! Sure, no problem. I will close this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet edited a comment on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-903373632
Hi @bytestreme we're redesigning the website and may have a new design for the drop-down list, so how about reverting your changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201#issuecomment-874448954
@tuteng does "show external or internal links" matter?
Just my two cents: generally users do not care whether it is an external or internal link. Besides, the space of the drop-down menus on the breadcrumb navigation is limited, removing unnecessary icons might be a better way to make the layout looks more organized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bytestreme closed pull request #11201: [docs] Fix 'Community' dropdown menu symbols
Posted by GitBox <gi...@apache.org>.
bytestreme closed pull request #11201:
URL: https://github.com/apache/pulsar/pull/11201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org