[GitHub] john-bodley opened a new pull request #3881: [linting] Cleaning up linting documentation

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #3881: [linting] Cleaning up linting documentation
URL: https://github.com/apache/incubator-superset/pull/3881
 
 
   Per @timifasubaa's suggestion I updated the linting logic in `CONTRIBUTING.md`. Simply running `flake8` or (`npm run lint` for that matter) doesn't work off the bat as one needs to i) install all the `flake8` extensions, and ii) cd to `superset/assets` respectively. 
   
   For the `flake8` case given that the configuration logic resides in the `tox.ini` file it seemed to make more sense to direct people to invoke `tox` locally for linting both Python and Javascript code. The later required an additional `tox` test environment which is not invoked by Travis since the `javascript` environment is a superset of `eslint`.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services