You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2025/09/25 20:37:48 UTC

[I] Make`LiteralPredicate` predicate JSON serializable [iceberg-python]

Fokko opened a new issue, #2523:
URL: https://github.com/apache/iceberg-python/issues/2523

   ### Feature Request / Improvement
   
   Make sure that the `LiteralPredicate` can be serialized to JSON:
   
   https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/expressions/__init__.py#L722
   
   This predicate has four implementations: `IsNull`, `NotNull`, `IsNaN`, and `NotNan`, and translates to:
   
   ```json
   {
       "type": "lt" // Or lt-eq, gt, gt-eq, eq, not-eq, starts-with, not-starts-with
       "term": str, // The column name
       "value": Any // Should be Literal, but we can do that later since that's not JSON serializable yet
   }
   ```
   
   We use Pydantic for JSON serialization, which can be enabled by deriving from the `IcebergBaseModel`:
   
   https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/partitioning.py#L124
   
   Example tests can be found here:
   
   https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/tests/table/test_partitioning.py#L116-L132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Make`LiteralPredicate` predicate JSON serializable [iceberg-python]

Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on issue #2523:
URL: https://github.com/apache/iceberg-python/issues/2523#issuecomment-3336211997

   Hi @Fokko,  can work on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Make`LiteralPredicate` predicate JSON serializable [iceberg-python]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #2523: Make`LiteralPredicate` predicate JSON serializable
URL: https://github.com/apache/iceberg-python/issues/2523


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Make`LiteralPredicate` predicate JSON serializable [iceberg-python]

Posted by "axwell0 (via GitHub)" <gi...@apache.org>.
axwell0 commented on issue #2523:
URL: https://github.com/apache/iceberg-python/issues/2523#issuecomment-3341709034

   May I take on this issue?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org