You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/08/11 17:11:58 UTC

[GitHub] underwoodb-sd-ibm commented on a change in pull request #2604: (WIP) Give more information in Activation lists

underwoodb-sd-ibm commented on a change in pull request #2604: (WIP) Give more information in Activation lists
URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737849
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala
 ##########
 @@ -62,7 +62,8 @@ case class WhiskActivation(
     version: SemVer = SemVer(),
     publish: Boolean = false,
     annotations: Parameters = Parameters(),
-    duration: Option[Long] = None)
+    duration: Option[Long] = None,
+    entityType: String)
 
 Review comment:
   Yea... I figured - I apologize for not having more done before making this PR, but today is my last official day as an intern, and I wanted to get the code up before I go. @mdeuser and I had a discussion about why this wasn't a good idea, but we already had it coded, and I haven't had time to change the implementation.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services