You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@causeway.apache.org by "danhaywood (via GitHub)" <gi...@apache.org> on 2023/06/23 09:19:53 UTC
[GitHub] [causeway] danhaywood opened a new pull request, #1755: CAUSEWAY-3498: skips validation of choices/defaults for always-hidden…
danhaywood opened a new pull request, #1755:
URL: https://github.com/apache/causeway/pull/1755
… actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@causeway.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [causeway] andi-huber commented on a diff in pull request #1755: CAUSEWAY-3498: skips validation of choices/defaults for always-hidden…
Posted by "andi-huber (via GitHub)" <gi...@apache.org>.
andi-huber commented on code in PR #1755:
URL: https://github.com/apache/causeway/pull/1755#discussion_r1239603405
##########
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/postprocessors/param/ChoicesAndDefaultsPostProcessor.java:
##########
@@ -68,6 +70,13 @@ public void postProcessParameter(
final ObjectAction objectAction,
final ObjectActionParameter param) {
+ // no need to check if this action is always hidden in the UI
+ // (eg if it exists solely to be called via the WrapperFactory service)
+ val hiddenFacet = objectAction.getFacet(HiddenFacet.class);
Review Comment:
We have convenient utility code for this in `Facets.hiddenWhere(...).`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@causeway.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [causeway] danhaywood merged pull request #1755: CAUSEWAY-3498: skips validation of choices/defaults for always-hidden…
Posted by "danhaywood (via GitHub)" <gi...@apache.org>.
danhaywood merged PR #1755:
URL: https://github.com/apache/causeway/pull/1755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@causeway.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [causeway] andi-huber commented on pull request #1755: CAUSEWAY-3498: skips validation of choices/defaults for always-hidden…
Posted by "andi-huber (via GitHub)" <gi...@apache.org>.
andi-huber commented on PR #1755:
URL: https://github.com/apache/causeway/pull/1755#issuecomment-1604279605
I like that one! Also useful for actions that are only exposed via RO, like in `@DomainService(nature=REST)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@causeway.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org