You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2021/01/22 18:12:16 UTC
[superset] branch master updated: Apply capitalization guidelines -
iteration 3 (#12343) (#12449)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 5d3265b Apply capitalization guidelines - iteration 3 (#12343) (#12449)
5d3265b is described below
commit 5d3265b6db41173579c4e9d1fa29c84c8baabc12
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Fri Jan 22 15:11:28 2021 -0300
Apply capitalization guidelines - iteration 3 (#12343) (#12449)
---
.../cypress-base/cypress/integration/dashboard/save.test.js | 2 +-
superset-frontend/src/CRUD/CollectionTable.tsx | 2 +-
superset-frontend/src/components/Menu/NewMenu.tsx | 2 +-
superset-frontend/src/components/Select/Select.stories.tsx | 2 +-
.../src/dashboard/components/ColorSchemeControlWrapper.jsx | 2 +-
superset-frontend/src/dashboard/components/CssEditor.jsx | 2 +-
superset-frontend/src/dashboard/components/Header.jsx | 4 ++--
.../src/dashboard/components/HeaderActionsDropdown.jsx | 4 ++--
superset-frontend/src/dashboard/components/PropertiesModal.jsx | 8 ++++----
.../src/dashboard/components/RefreshIntervalModal.tsx | 2 +-
superset-frontend/src/dashboard/components/SaveModal.tsx | 2 +-
11 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/superset-frontend/cypress-base/cypress/integration/dashboard/save.test.js b/superset-frontend/cypress-base/cypress/integration/dashboard/save.test.js
index 0d2b48e..0822081 100644
--- a/superset-frontend/cypress-base/cypress/integration/dashboard/save.test.js
+++ b/superset-frontend/cypress-base/cypress/integration/dashboard/save.test.js
@@ -97,7 +97,7 @@ describe('Dashboard save action', () => {
// open color scheme dropdown
cy.get('.ant-modal-body')
- .contains('Color Scheme')
+ .contains('Color scheme')
.parents('.ControlHeader')
.next('.Select')
.click()
diff --git a/superset-frontend/src/CRUD/CollectionTable.tsx b/superset-frontend/src/CRUD/CollectionTable.tsx
index 480e593..8166034 100644
--- a/superset-frontend/src/CRUD/CollectionTable.tsx
+++ b/superset-frontend/src/CRUD/CollectionTable.tsx
@@ -314,7 +314,7 @@ export default class CRUDCollection extends React.PureComponent<
data-test="add-item-button"
>
<i data-test="crud-add-table-item" className="fa fa-plus" />{' '}
- {t('Add Item')}
+ {t('Add item')}
</Button>
</span>
)}
diff --git a/superset-frontend/src/components/Menu/NewMenu.tsx b/superset-frontend/src/components/Menu/NewMenu.tsx
index a9e2a90..d13ed1a 100644
--- a/superset-frontend/src/components/Menu/NewMenu.tsx
+++ b/superset-frontend/src/components/Menu/NewMenu.tsx
@@ -23,7 +23,7 @@ import NavDropdown from 'src/components/NavDropdown';
const dropdownItems = [
{
- label: t('SQL Query'),
+ label: t('SQL query'),
url: '/superset/sqllab',
icon: 'fa-fw fa-search',
},
diff --git a/superset-frontend/src/components/Select/Select.stories.tsx b/superset-frontend/src/components/Select/Select.stories.tsx
index dc10420..72cffdd 100644
--- a/superset-frontend/src/components/Select/Select.stories.tsx
+++ b/superset-frontend/src/components/Select/Select.stories.tsx
@@ -28,7 +28,7 @@ const OPTIONS = [
];
export default {
- title: 'Select Component',
+ title: 'Select component',
argTypes: {
options: {
type: 'select',
diff --git a/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx b/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
index 21db6ba..871dad6 100644
--- a/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
+++ b/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
@@ -53,7 +53,7 @@ class ColorSchemeControlWrapper extends React.PureComponent {
description={t(
"Any color palette selected here will override the colors applied to this dashboard's individual charts",
)}
- label={t('Color Scheme')}
+ label={t('Color scheme')}
name="color_scheme"
onChange={this.props.onChange}
value={colorScheme}
diff --git a/superset-frontend/src/dashboard/components/CssEditor.jsx b/superset-frontend/src/dashboard/components/CssEditor.jsx
index 396276f..19cfd1c 100644
--- a/superset-frontend/src/dashboard/components/CssEditor.jsx
+++ b/superset-frontend/src/dashboard/components/CssEditor.jsx
@@ -85,7 +85,7 @@ class CssEditor extends React.PureComponent {
<div>
{this.renderTemplateSelector()}
<div style={{ zIndex: 1 }}>
- <h5>{t('Live CSS Editor')}</h5>
+ <h5>{t('Live CSS editor')}</h5>
<div style={{ border: 'solid 1px grey' }}>
<AceCssEditor
minLines={12}
diff --git a/superset-frontend/src/dashboard/components/Header.jsx b/superset-frontend/src/dashboard/components/Header.jsx
index 9ef5471..e155413 100644
--- a/superset-frontend/src/dashboard/components/Header.jsx
+++ b/superset-frontend/src/dashboard/components/Header.jsx
@@ -456,7 +456,7 @@ class Header extends React.PureComponent {
buttonStyle="default"
data-test="discard-changes-button"
>
- {t('Discard Changes')}
+ {t('Discard changes')}
</Button>
<Button
buttonSize="small"
@@ -482,7 +482,7 @@ class Header extends React.PureComponent {
<>
<span
role="button"
- title="Edit Dashboard"
+ title="Edit dashboard"
tabIndex={0}
className="action-button"
onClick={this.toggleEditMode}
diff --git a/superset-frontend/src/dashboard/components/HeaderActionsDropdown.jsx b/superset-frontend/src/dashboard/components/HeaderActionsDropdown.jsx
index b18056d..e5eafa4 100644
--- a/superset-frontend/src/dashboard/components/HeaderActionsDropdown.jsx
+++ b/superset-frontend/src/dashboard/components/HeaderActionsDropdown.jsx
@@ -201,7 +201,7 @@ class HeaderActionsDropdown extends React.PureComponent {
lastModifiedTime,
} = this.props;
- const emailTitle = t('Superset Dashboard');
+ const emailTitle = t('Superset dashboard');
const emailSubject = `${emailTitle} ${dashboardTitle}`;
const emailBody = t('Check out this dashboard: ');
@@ -302,7 +302,7 @@ class HeaderActionsDropdown extends React.PureComponent {
{!editMode && (
<Menu.Item key={MENU_KEYS.TOGGLE_FULLSCREEN}>
- {t('Toggle FullScreen')}
+ {t('Toggle fullscreen')}
</Menu.Item>
)}
</Menu>
diff --git a/superset-frontend/src/dashboard/components/PropertiesModal.jsx b/superset-frontend/src/dashboard/components/PropertiesModal.jsx
index 1cc75b1..f45f483 100644
--- a/superset-frontend/src/dashboard/components/PropertiesModal.jsx
+++ b/superset-frontend/src/dashboard/components/PropertiesModal.jsx
@@ -292,7 +292,7 @@ class PropertiesModal extends React.PureComponent {
<Modal
show={this.props.show}
onHide={this.props.onHide}
- title={t('Dashboard Properties')}
+ title={t('Dashboard properties')}
footer={
<>
<Button
@@ -321,7 +321,7 @@ class PropertiesModal extends React.PureComponent {
<form data-test="dashboard-edit-properties-form" onSubmit={this.submit}>
<Row>
<Col md={12}>
- <h3>{t('Basic Information')}</h3>
+ <h3>{t('Basic information')}</h3>
</Col>
</Row>
<Row>
@@ -338,7 +338,7 @@ class PropertiesModal extends React.PureComponent {
/>
</Col>
<Col md={6}>
- <FormLabel htmlFor="embed-height">{t('URL Slug')}</FormLabel>
+ <FormLabel htmlFor="embed-height">{t('URL slug')}</FormLabel>
<FormControl
name="slug"
type="text"
@@ -397,7 +397,7 @@ class PropertiesModal extends React.PureComponent {
{isAdvancedOpen && (
<>
<FormLabel htmlFor="json_metadata">
- {t('JSON Metadata')}
+ {t('JSON metadata')}
</FormLabel>
<StyledJsonEditor
showLoadingForImport
diff --git a/superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx b/superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
index 9be1dd7..a16b457 100644
--- a/superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
+++ b/superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
@@ -112,7 +112,7 @@ class RefreshIntervalModal extends React.PureComponent<
<StyledModalTrigger
ref={this.modalRef}
triggerNode={this.props.triggerNode}
- modalTitle={t('Refresh Interval')}
+ modalTitle={t('Refresh interval')}
modalBody={
<div>
<FormLabel>{t('Refresh frequency')}</FormLabel>
diff --git a/superset-frontend/src/dashboard/components/SaveModal.tsx b/superset-frontend/src/dashboard/components/SaveModal.tsx
index c8f327b..a377edb 100644
--- a/superset-frontend/src/dashboard/components/SaveModal.tsx
+++ b/superset-frontend/src/dashboard/components/SaveModal.tsx
@@ -178,7 +178,7 @@ class SaveModal extends React.PureComponent<SaveModalProps, SaveModalState> {
<ModalTrigger
ref={this.setModalRef}
triggerNode={this.props.triggerNode}
- modalTitle={t('Save Dashboard')}
+ modalTitle={t('Save dashboard')}
modalBody={
<FormGroup>
<Radio