[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1942: IGNITE-19193 Store sensitive CLI config separately

["PakhomovAlexander (via GitHub)" <gi...@apache.org>]

PakhomovAlexander commented on code in PR #1942:
URL: https://github.com/apache/ignite-3/pull/1942#discussion_r1168397312


##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/config/CliConfigKeys.java:
##########
@@ -53,6 +57,23 @@ public String value() {
         return value;
     }
 
+    /**
+     * Returns all secret config keys.
+     */
+    public static Set<String> secretConfigKeys() {
+        return Set.of(
+                        REST_KEY_STORE_PASSWORD,
+                        REST_KEY_STORE_PATH,

Review Comment:
   I don't think that the path is sensitive information. But we could discuss it.



##########
modules/cli/src/test/java/org/apache/ignite/internal/cli/commands/CliCommandTestBase.java:
##########
@@ -102,9 +105,10 @@ protected void assertOutputIs(String expectedOutput) {
                 .isEqualTo(expectedOutput);
     }
 
-    protected void assertOutputContains(String expectedOutput) {
+    protected void assertOutputContains(String... expectedOutput) {
+        Set<String> expectedStrings = Arrays.stream(expectedOutput).collect(Collectors.toSet());
         assertThat(sout.toString())
-                .as("Expected command output to contain: " + expectedOutput + " but was " + sout.toString())
+                .as("Expected command output to contain: " + expectedStrings + " but was " + sout.toString())

Review Comment:
   What is this change for?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org