You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by gn...@apache.org on 2016/03/09 10:19:39 UTC
[2/2] mina-sshd git commit: [SSHD-646] ThreadGroup created in
ThreadUtils is not destroyed and causes memory leak
[SSHD-646] ThreadGroup created in ThreadUtils is not destroyed and causes memory leak
Project: http://git-wip-us.apache.org/repos/asf/mina-sshd/repo
Commit: http://git-wip-us.apache.org/repos/asf/mina-sshd/commit/cdcdecdf
Tree: http://git-wip-us.apache.org/repos/asf/mina-sshd/tree/cdcdecdf
Diff: http://git-wip-us.apache.org/repos/asf/mina-sshd/diff/cdcdecdf
Branch: refs/heads/1.1.x
Commit: cdcdecdf20fde9ca3dd973e6975636644bcd26c5
Parents: 7b058e3
Author: Lyor Goldstein <ly...@gmail.com>
Authored: Thu Feb 25 09:49:11 2016 +0200
Committer: Guillaume Nodet <gn...@apache.org>
Committed: Wed Mar 9 10:19:14 2016 +0100
----------------------------------------------------------------------
.../java/org/apache/sshd/common/util/threads/ThreadUtils.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/cdcdecdf/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java b/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
index d0a25ed..9008635 100644
--- a/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
+++ b/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java
@@ -163,9 +163,8 @@ public final class ThreadUtils {
public SshdThreadFactory(String name) {
SecurityManager s = System.getSecurityManager();
- ThreadGroup parentGroup = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
+ group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
String effectiveName = name.replace(' ', '-');
- group = new ThreadGroup(parentGroup, "sshd-" + effectiveName + "-group");
namePrefix = "sshd-" + effectiveName + "-thread-";
}