You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by ce...@apache.org on 2004/05/28 21:30:18 UTC
cvs commit: logging-log4j/src/java/org/apache/log4j/rolling RollingFileAppender.java SlidingWindowRollingPolicy.java TimeBasedRollingPolicy.java
ceki 2004/05/28 12:30:17
Modified: src/java/org/apache/log4j/rolling RollingFileAppender.java
SlidingWindowRollingPolicy.java
TimeBasedRollingPolicy.java
Log:
RollingFileAppender no longer activates subcomponents. This is inline with the
way JoranConfigurator handles configuration of sub-component activation.
Revision Changes Path
1.16 +3 -1 logging-log4j/src/java/org/apache/log4j/rolling/RollingFileAppender.java
Index: RollingFileAppender.java
===================================================================
RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/rolling/RollingFileAppender.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- RollingFileAppender.java 28 May 2004 17:16:43 -0000 1.15
+++ RollingFileAppender.java 28 May 2004 19:30:17 -0000 1.16
@@ -55,7 +55,9 @@
}
if (rollingPolicy != null) {
- rollingPolicy.activateOptions();
+ // Sub components must be activated separately
+ //rollingPolicy.activateOptions();
+
String afn = rollingPolicy.getActiveLogFileName();
activeFile = new File(afn);
logger.debug("Active log file name: "+afn);
1.11 +1 -0 logging-log4j/src/java/org/apache/log4j/rolling/SlidingWindowRollingPolicy.java
Index: SlidingWindowRollingPolicy.java
===================================================================
RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/rolling/SlidingWindowRollingPolicy.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- SlidingWindowRollingPolicy.java 27 Feb 2004 16:47:33 -0000 1.10
+++ SlidingWindowRollingPolicy.java 28 May 2004 19:30:17 -0000 1.11
@@ -17,6 +17,7 @@
package org.apache.log4j.rolling;
import org.apache.log4j.Logger;
+import org.apache.log4j.helpers.LogLog;
import org.apache.log4j.rolling.helpers.Compress;
import org.apache.log4j.rolling.helpers.FileNamePattern;
import org.apache.log4j.rolling.helpers.Util;
1.6 +3 -1 logging-log4j/src/java/org/apache/log4j/rolling/TimeBasedRollingPolicy.java
Index: TimeBasedRollingPolicy.java
===================================================================
RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/rolling/TimeBasedRollingPolicy.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- TimeBasedRollingPolicy.java 27 Feb 2004 16:47:33 -0000 1.5
+++ TimeBasedRollingPolicy.java 28 May 2004 19:30:17 -0000 1.6
@@ -31,7 +31,9 @@
/**
*
*
- *
+ * If configuring programatically, do not forget to call {@link #activateOptions}
+ * method before using this policy.
+ *
* @author Ceki Gülcü
*/
public class TimeBasedRollingPolicy extends RollingPolicySkeleton
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org