You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/07 23:12:57 UTC
[GitHub] [nifi] mattyb149 opened a new pull request #4750: NIFI-7989: Add Update Field Names and Record Writer to UpdateHiveTable processors
mattyb149 opened a new pull request #4750:
URL: https://github.com/apache/nifi/pull/4750
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Hive is mostly case-insensitive but in the case where tables are backed by Avro, the field names in the embedded Avro schemas must exactly match the corresponding table columns. For this kind of use case, it would be helpful to (optionally) update the record schema to match the table schema exactly. To update the record schema, all records have to be rewritten, so a Record Writer property (dependent on Update Field Names set to true) needs to be added.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [x] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4750: NIFI-7989: Add Update Field Names and Record Writer to UpdateHiveTable processors
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #4750:
URL: https://github.com/apache/nifi/pull/4750#discussion_r555945721
##########
File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive_1_1-processors/src/main/java/org/apache/nifi/processors/hive/UpdateHive_1_1Table.java
##########
@@ -562,7 +686,35 @@ private synchronized void checkAndUpdateTableSchema(final ProcessSession session
outputPath = tableLocation + "/" + String.join("/", partitionColumnsLocationList);
}
- session.putAttribute(flowFile, ATTR_OUTPUT_PATH, outputPath);
+ // If updating field names, return a new RecordSchema, otherwise return null
+ OutputMetadataHolder outputMetadataHolder;
+ if (!tableCreated && updateFieldNames) {
+ List<RecordField> inputRecordFields = schema.getFields();
+ List<RecordField> outputRecordFields = new ArrayList<>();
+ Map<String,String> fieldMap = new HashMap<>();
+
+ for (RecordField inputRecordField : inputRecordFields) {
+ final String inputRecordFieldName = inputRecordField.getFieldName();
+ boolean found = false;
+ for (String hiveColumnName : hiveColumns) {
+ if (inputRecordFieldName.equalsIgnoreCase(hiveColumnName)) {
Review comment:
If 'Update Fields Names' has been set to true, it always remap the records. Even if all the columns names are identical and the conversion would not be needed. It could be optimised to convert the records only if necessary.
In that case the record reader and writer must have the same data format because some FFs will be converted while others will not. Actually, it is already a requirement for a create + update scenario (create never converts) and should be documented for the users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4750: NIFI-7989: Add Update Field Names and Record Writer to UpdateHiveTable processors
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4750:
URL: https://github.com/apache/nifi/pull/4750#discussion_r556021114
##########
File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive_1_1-processors/src/main/java/org/apache/nifi/processors/hive/UpdateHive_1_1Table.java
##########
@@ -562,7 +686,35 @@ private synchronized void checkAndUpdateTableSchema(final ProcessSession session
outputPath = tableLocation + "/" + String.join("/", partitionColumnsLocationList);
}
- session.putAttribute(flowFile, ATTR_OUTPUT_PATH, outputPath);
+ // If updating field names, return a new RecordSchema, otherwise return null
+ OutputMetadataHolder outputMetadataHolder;
+ if (!tableCreated && updateFieldNames) {
+ List<RecordField> inputRecordFields = schema.getFields();
+ List<RecordField> outputRecordFields = new ArrayList<>();
+ Map<String,String> fieldMap = new HashMap<>();
+
+ for (RecordField inputRecordField : inputRecordFields) {
+ final String inputRecordFieldName = inputRecordField.getFieldName();
+ boolean found = false;
+ for (String hiveColumnName : hiveColumns) {
+ if (inputRecordFieldName.equalsIgnoreCase(hiveColumnName)) {
Review comment:
Agreed, I will change the behavior and add the appropriate documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4750: NIFI-7989: Add Update Field Names and Record Writer to UpdateHiveTable processors
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4750:
URL: https://github.com/apache/nifi/pull/4750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org