You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Steve (JIRA)" <ji...@apache.org> on 2009/05/15 21:42:50 UTC
[jira] Created: (AMQ-2254) NullPointerException on invalid STOMP
message
NullPointerException on invalid STOMP message
---------------------------------------------
Key: AMQ-2254
URL: https://issues.apache.org/activemq/browse/AMQ-2254
Project: ActiveMQ
Issue Type: Bug
Components: Broker
Affects Versions: 5.2.0
Environment: Linux (Ubuntu 8.04), x86, Java 1.6.0_07
Reporter: Steve
Priority: Minor
I discovered accidentally that the following invalid STOMP conversation will reliably cause a NullPointerException in activemq:
cli> CONNECT
cli> ['username: ', 'password: ']
srv> CONNECTED
srv> session:ID:slc1-40603-1242413649494-4:9
cli> SUBSCRIBE
cli> ['ack: client', 'destination: /queue/raw_input']
java.lang.NullPointerException
at org.apache.activemq.broker.region.RegionBroker.addConsumer(RegionBroker.java:370)
at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
at org.apache.activemq.advisory.AdvisoryBroker.addConsumer(AdvisoryBroker.java:83)
at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
at org.apache.activemq.broker.MutableBrokerFilter.addConsumer(MutableBrokerFilter.java:93)
at org.apache.activemq.broker.TransportConnection.processAddConsumer(TransportConnection.java:541)
at org.apache.activemq.command.ConsumerInfo.visit(ConsumerInfo.java:345)
at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:179)
at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
at org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
at org.apache.activemq.transport.stomp.ProtocolConverter.onStompSubscribe(ProtocolConverter.java:399)
at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:183)
at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
at java.lang.Thread.run(Thread.java:619)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-2254) NullPointerException on invalid STOMP
message
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-2254.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.4.0
Patch applied in SVN: 906088.
> NullPointerException on invalid STOMP message
> ---------------------------------------------
>
> Key: AMQ-2254
> URL: https://issues.apache.org/activemq/browse/AMQ-2254
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Environment: Linux (Ubuntu 8.04), x86, Java 1.6.0_07
> Reporter: Steve
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 5.4.0
>
> Attachments: AMQ-2254.patch
>
>
> I discovered accidentally that the following invalid STOMP conversation will reliably cause a NullPointerException in activemq:
> cli> CONNECT
> cli> ['username: ', 'password: ']
> srv> CONNECTED
> srv> session:ID:slc1-40603-1242413649494-4:9
> cli> SUBSCRIBE
> cli> ['ack: client', 'destination: /queue/raw_input']
> java.lang.NullPointerException
> at org.apache.activemq.broker.region.RegionBroker.addConsumer(RegionBroker.java:370)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.advisory.AdvisoryBroker.addConsumer(AdvisoryBroker.java:83)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.MutableBrokerFilter.addConsumer(MutableBrokerFilter.java:93)
> at org.apache.activemq.broker.TransportConnection.processAddConsumer(TransportConnection.java:541)
> at org.apache.activemq.command.ConsumerInfo.visit(ConsumerInfo.java:345)
> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:179)
> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
> at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
> at org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompSubscribe(ProtocolConverter.java:399)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:183)
> at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
> at java.lang.Thread.run(Thread.java:619)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2254) NullPointerException on invalid STOMP
message
Posted by "Giovani Seben (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giovani Seben updated AMQ-2254:
-------------------------------
Attachment: AMQ-2254.patch
> NullPointerException on invalid STOMP message
> ---------------------------------------------
>
> Key: AMQ-2254
> URL: https://issues.apache.org/activemq/browse/AMQ-2254
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Environment: Linux (Ubuntu 8.04), x86, Java 1.6.0_07
> Reporter: Steve
> Priority: Minor
> Attachments: AMQ-2254.patch
>
>
> I discovered accidentally that the following invalid STOMP conversation will reliably cause a NullPointerException in activemq:
> cli> CONNECT
> cli> ['username: ', 'password: ']
> srv> CONNECTED
> srv> session:ID:slc1-40603-1242413649494-4:9
> cli> SUBSCRIBE
> cli> ['ack: client', 'destination: /queue/raw_input']
> java.lang.NullPointerException
> at org.apache.activemq.broker.region.RegionBroker.addConsumer(RegionBroker.java:370)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.advisory.AdvisoryBroker.addConsumer(AdvisoryBroker.java:83)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.MutableBrokerFilter.addConsumer(MutableBrokerFilter.java:93)
> at org.apache.activemq.broker.TransportConnection.processAddConsumer(TransportConnection.java:541)
> at org.apache.activemq.command.ConsumerInfo.visit(ConsumerInfo.java:345)
> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:179)
> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
> at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
> at org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompSubscribe(ProtocolConverter.java:399)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:183)
> at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
> at java.lang.Thread.run(Thread.java:619)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2254) NullPointerException on invalid STOMP
message
Posted by "Giovani Seben (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giovani Seben updated AMQ-2254:
-------------------------------
Patch Info: [Patch Available]
> NullPointerException on invalid STOMP message
> ---------------------------------------------
>
> Key: AMQ-2254
> URL: https://issues.apache.org/activemq/browse/AMQ-2254
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Environment: Linux (Ubuntu 8.04), x86, Java 1.6.0_07
> Reporter: Steve
> Priority: Minor
> Attachments: AMQ-2254.patch
>
>
> I discovered accidentally that the following invalid STOMP conversation will reliably cause a NullPointerException in activemq:
> cli> CONNECT
> cli> ['username: ', 'password: ']
> srv> CONNECTED
> srv> session:ID:slc1-40603-1242413649494-4:9
> cli> SUBSCRIBE
> cli> ['ack: client', 'destination: /queue/raw_input']
> java.lang.NullPointerException
> at org.apache.activemq.broker.region.RegionBroker.addConsumer(RegionBroker.java:370)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.advisory.AdvisoryBroker.addConsumer(AdvisoryBroker.java:83)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.MutableBrokerFilter.addConsumer(MutableBrokerFilter.java:93)
> at org.apache.activemq.broker.TransportConnection.processAddConsumer(TransportConnection.java:541)
> at org.apache.activemq.command.ConsumerInfo.visit(ConsumerInfo.java:345)
> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:179)
> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
> at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
> at org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompSubscribe(ProtocolConverter.java:399)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:183)
> at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
> at java.lang.Thread.run(Thread.java:619)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQ-2254) NullPointerException on invalid STOMP
message
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish reassigned AMQ-2254:
---------------------------------
Assignee: Timothy Bish
> NullPointerException on invalid STOMP message
> ---------------------------------------------
>
> Key: AMQ-2254
> URL: https://issues.apache.org/activemq/browse/AMQ-2254
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Environment: Linux (Ubuntu 8.04), x86, Java 1.6.0_07
> Reporter: Steve
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 5.4.0
>
> Attachments: AMQ-2254.patch
>
>
> I discovered accidentally that the following invalid STOMP conversation will reliably cause a NullPointerException in activemq:
> cli> CONNECT
> cli> ['username: ', 'password: ']
> srv> CONNECTED
> srv> session:ID:slc1-40603-1242413649494-4:9
> cli> SUBSCRIBE
> cli> ['ack: client', 'destination: /queue/raw_input']
> java.lang.NullPointerException
> at org.apache.activemq.broker.region.RegionBroker.addConsumer(RegionBroker.java:370)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.advisory.AdvisoryBroker.addConsumer(AdvisoryBroker.java:83)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.MutableBrokerFilter.addConsumer(MutableBrokerFilter.java:93)
> at org.apache.activemq.broker.TransportConnection.processAddConsumer(TransportConnection.java:541)
> at org.apache.activemq.command.ConsumerInfo.visit(ConsumerInfo.java:345)
> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:179)
> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
> at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
> at org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompSubscribe(ProtocolConverter.java:399)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:183)
> at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
> at java.lang.Thread.run(Thread.java:619)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-2254) NullPointerException on invalid STOMP
message
Posted by "Giovani Seben (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52822#action_52822 ]
Giovani Seben commented on AMQ-2254:
------------------------------------
The invalid subscribe causes the problem. Added a simple check to the ProtocolConverter.
> NullPointerException on invalid STOMP message
> ---------------------------------------------
>
> Key: AMQ-2254
> URL: https://issues.apache.org/activemq/browse/AMQ-2254
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.2.0
> Environment: Linux (Ubuntu 8.04), x86, Java 1.6.0_07
> Reporter: Steve
> Priority: Minor
> Attachments: AMQ-2254.patch
>
>
> I discovered accidentally that the following invalid STOMP conversation will reliably cause a NullPointerException in activemq:
> cli> CONNECT
> cli> ['username: ', 'password: ']
> srv> CONNECTED
> srv> session:ID:slc1-40603-1242413649494-4:9
> cli> SUBSCRIBE
> cli> ['ack: client', 'destination: /queue/raw_input']
> java.lang.NullPointerException
> at org.apache.activemq.broker.region.RegionBroker.addConsumer(RegionBroker.java:370)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.advisory.AdvisoryBroker.addConsumer(AdvisoryBroker.java:83)
> at org.apache.activemq.broker.BrokerFilter.addConsumer(BrokerFilter.java:86)
> at org.apache.activemq.broker.MutableBrokerFilter.addConsumer(MutableBrokerFilter.java:93)
> at org.apache.activemq.broker.TransportConnection.processAddConsumer(TransportConnection.java:541)
> at org.apache.activemq.command.ConsumerInfo.visit(ConsumerInfo.java:345)
> at org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:305)
> at org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:179)
> at org.apache.activemq.transport.TransportFilter.onCommand(TransportFilter.java:68)
> at org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:78)
> at org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:135)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompSubscribe(ProtocolConverter.java:399)
> at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommad(ProtocolConverter.java:183)
> at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:67)
> at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:84)
> at org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:203)
> at org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:185)
> at java.lang.Thread.run(Thread.java:619)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.