You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/01/09 02:38:22 UTC

Review Request 29744: Replaced Resources::Transformation with Resources::Transform.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29744/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu.


Repository: mesos-git


Description
-------

An abstraction to transform `Resources` with the possible transformations tied to the `Resource::Operation`s.


Diffs
-----

  include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
  src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 

Diff: https://reviews.apache.org/r/29744/diff/


Testing
-------

make check


Thanks,

Michael Park


Re: Review Request 29744: Replaced Resources::Transformation with Resources::apply.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29744/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 7:47 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.


Repository: mesos-git


Description
-------

Replaced Resources::Transfomration with Resources::apply. Resources::apply takes a vector of Offer::Operations and returns the resulting Resources after the operations.


Diffs
-----

  include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
  src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
  src/master/allocator.hpp 224569a55eb15d9e7c63f2b571a1f9ae8cd4b6e6 
  src/master/hierarchical_allocator_process.hpp ccd37b4348c785ece890257f805777acbaf8d58c 
  src/tests/hierarchical_allocator_tests.cpp 7c051232f2c70691a7789e0f3e94f0e4cba26f18 
  src/tests/mesos.hpp f93c3f128412e94dee3b7806df55807aa578305d 
  src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a 
  src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489 

Diff: https://reviews.apache.org/r/29744/diff/


Testing
-------

make check


Thanks,

Michael Park


Re: Review Request 29744: Replaced Resources::Transformation with Resources::apply.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29744/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 7:46 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.


Repository: mesos-git


Description (updated)
-------

Replaced Resources::Transfomration with Resources::apply. Resources::apply takes a vector of Offer::Operations and returns the resulting Resources after the operations.


Diffs
-----

  include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
  src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
  src/master/allocator.hpp 224569a55eb15d9e7c63f2b571a1f9ae8cd4b6e6 
  src/master/hierarchical_allocator_process.hpp ccd37b4348c785ece890257f805777acbaf8d58c 
  src/tests/hierarchical_allocator_tests.cpp 7c051232f2c70691a7789e0f3e94f0e4cba26f18 
  src/tests/mesos.hpp f93c3f128412e94dee3b7806df55807aa578305d 
  src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a 
  src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489 

Diff: https://reviews.apache.org/r/29744/diff/


Testing
-------

make check


Thanks,

Michael Park


Re: Review Request 29744: Replaced Resources::Transformation with Resources::apply.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29744/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 7:45 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.


Summary (updated)
-----------------

Replaced Resources::Transformation with Resources::apply.


Repository: mesos-git


Description
-------

An abstraction to transform `Resources` with the possible transformations tied to the `Resource::Operation`s.


Diffs
-----

  include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
  src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
  src/master/allocator.hpp 224569a55eb15d9e7c63f2b571a1f9ae8cd4b6e6 
  src/master/hierarchical_allocator_process.hpp ccd37b4348c785ece890257f805777acbaf8d58c 
  src/tests/hierarchical_allocator_tests.cpp 7c051232f2c70691a7789e0f3e94f0e4cba26f18 
  src/tests/mesos.hpp f93c3f128412e94dee3b7806df55807aa578305d 
  src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a 
  src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489 

Diff: https://reviews.apache.org/r/29744/diff/


Testing
-------

make check


Thanks,

Michael Park


Re: Review Request 29744: Replaced Resources::Transformation with Resources::Transform.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29744/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 7:45 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.


Repository: mesos-git


Description
-------

An abstraction to transform `Resources` with the possible transformations tied to the `Resource::Operation`s.


Diffs (updated)
-----

  include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
  src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
  src/master/allocator.hpp 224569a55eb15d9e7c63f2b571a1f9ae8cd4b6e6 
  src/master/hierarchical_allocator_process.hpp ccd37b4348c785ece890257f805777acbaf8d58c 
  src/tests/hierarchical_allocator_tests.cpp 7c051232f2c70691a7789e0f3e94f0e4cba26f18 
  src/tests/mesos.hpp f93c3f128412e94dee3b7806df55807aa578305d 
  src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a 
  src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489 

Diff: https://reviews.apache.org/r/29744/diff/


Testing
-------

make check


Thanks,

Michael Park


Re: Review Request 29744: Replaced Resources::Transformation with Resources::Transform.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29744/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 6:38 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.


Repository: mesos-git


Description
-------

An abstraction to transform `Resources` with the possible transformations tied to the `Resource::Operation`s.


Diffs (updated)
-----

  include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
  src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 
  src/master/allocator.hpp 224569a55eb15d9e7c63f2b571a1f9ae8cd4b6e6 
  src/master/hierarchical_allocator_process.hpp ccd37b4348c785ece890257f805777acbaf8d58c 
  src/tests/hierarchical_allocator_tests.cpp 7c051232f2c70691a7789e0f3e94f0e4cba26f18 
  src/tests/mesos.hpp f93c3f128412e94dee3b7806df55807aa578305d 
  src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a 
  src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489 

Diff: https://reviews.apache.org/r/29744/diff/


Testing
-------

make check


Thanks,

Michael Park


Re: Review Request 29744: Replaced Resources::Transformation with Resources::Transform.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29744/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 1:53 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.


Repository: mesos-git


Description
-------

An abstraction to transform `Resources` with the possible transformations tied to the `Resource::Operation`s.


Diffs
-----

  include/mesos/resources.hpp f1517b73def9aff4039f95a89f66208ba1d21c0f 
  src/common/resources.cpp c17e1791130e7d545bb7cdd54d97d65325d3a69e 

Diff: https://reviews.apache.org/r/29744/diff/


Testing
-------

make check


Thanks,

Michael Park