You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by Matt Foley <mf...@hortonworks.com> on 2017/08/01 01:36:08 UTC
Re: Code style change requires vote?
Hi Justin,
Technically, acceptance into the code base with appropriate review and +1’s signifies lazy consensus of all committers (since any committer can blackball a PR with a single justified -1).
If you (or any community member) is concerned that people didn’t have sufficient opportunity to review, OR passed on the opportunity to review because they didn’t understand the importance of the issue, then it is a good-citizen thing to bring it up in the mailing list -- as you have now done. (You’re a gentleman and a scholar!)
If the community has accepted enforcement of coding style via robot, then documenting that behavior seems an appropriate thing to do, certainly not requiring a vote on its own. (Please do!) So the question is, did the community _really_ accept it?
I looked over the history of PR#577, and it sure looks to me like the community accepted it with (lengthy) review, due consideration, and two enthusiastic +1’s.
As people actually experience the results, there’s always opportunity for second thoughts and fine tuning. I’d say go with the commit, and thanks for the contribution!
--Matt
On 7/31/17, 12:30 PM, "Justin Leet" <ju...@gmail.com> wrote:
That PR apparently got merged; I should have noted on the PR that this
thread got started.
Now there's a new potentially a new question: If that change required a
vote, what's the way we want to handle it? Do we revert it or leave it and
just follow-on with a PR for any changes we choose to make during
discussion / vote?
Obviously, this is moot if the answer is we don't need a vote since that PR
did have the appropriate +1's. At that point, I'd send an email calling it
out and make the appropriate wiki changes for getting people setup.
On Mon, Jul 31, 2017 at 1:50 PM, Justin Leet <ju...@gmail.com> wrote:
> Hi all,
>
> There was a bit of confusion on code style on at least one ticket,
> indirectly related to https://github.com/apache/metron/pull/577. For a
> refresher (and also because GitHub is being iffy today), that PR is about
> moving to the Google Code Style as discussed in [DISCUSS] Code Style
> <https://lists.apache.org/thread.html/bd8afff9ad4fe83feb5e7fdfd5d136947665fd6e4e9856807d06e9a3@%3Cdev.metron.apache.org%3E>
>
> The feedback in that thread was positive, but no formal vote was done.
> I've found at least one vote thread for dev guidelines in the past, but
> it's also not part of the bylaws page itself. Does this require just
> discussion/community consensus, or does it require (or do we just want) a
> vote? And is that in line with what other projects tend to do (if we
> choose to fo
>
> If we're of the opinion that it requires a vote, I'll happy to kick up a
> discuss thread with the proposed change, get feedback, and run a vote. It
> just delays when the change hits.
>
Re: Code style change requires vote?
Posted by Michael Miklavcic <mi...@gmail.com>.
Justin, this is great! Thanks again for the contribution as well as for the
follow-up and clarification on dev guidelines as well as community vote,
etc. I was under the impression that while the end goal is implicit, ie
using the new standard henceforth, that there was some follow on work
towards community agreement and migrating the existing code base to
conforming to the new standards per this comment in the PR - "No
enforcement of Checkstyle is made, and in fact, by default checkstyle.xml
sets everything to warning." However, Matt's comments seem to address any
ambiguity here since we had 2 +1's on the ticket. Thanks for the
clarification on this, Matt. For my own part I will send out a courtesy
notice to the dev list before merging PR's like this in the future. While
the checkstyle changes are passive in nature (ie, not enforced in the
build), I think it's still a good practice to connect the dots between
discuss threads and relevant PR's.
M
On Mon, Jul 31, 2017 at 7:42 PM, Justin Leet <ju...@gmail.com> wrote:
> Thanks a lot for the perspective, Matt, this is really good to have and I
> appreciate you taking the time to review everything and give a solid
> response.
>
> I'm going to go ahead and give a specific email to the list outlining style
> change and the instructions for improving the IDE experience. I'll double
> check, but I believe I'll need wiki permissions to be able to update that
> page.
>
> If anybody has any concerns or other thoughts, feel free to respond, and
> we'll figure out what else we want to do.
>
> On Mon, Jul 31, 2017 at 9:36 PM, Matt Foley <mf...@hortonworks.com>
> wrote:
>
> > Hi Justin,
> > Technically, acceptance into the code base with appropriate review and
> > +1’s signifies lazy consensus of all committers (since any committer can
> > blackball a PR with a single justified -1).
> >
> > If you (or any community member) is concerned that people didn’t have
> > sufficient opportunity to review, OR passed on the opportunity to review
> > because they didn’t understand the importance of the issue, then it is a
> > good-citizen thing to bring it up in the mailing list -- as you have now
> > done. (You’re a gentleman and a scholar!)
> >
> > If the community has accepted enforcement of coding style via robot, then
> > documenting that behavior seems an appropriate thing to do, certainly not
> > requiring a vote on its own. (Please do!) So the question is, did the
> > community _really_ accept it?
> >
> > I looked over the history of PR#577, and it sure looks to me like the
> > community accepted it with (lengthy) review, due consideration, and two
> > enthusiastic +1’s.
> >
> > As people actually experience the results, there’s always opportunity for
> > second thoughts and fine tuning. I’d say go with the commit, and thanks
> > for the contribution!
> >
> > --Matt
> >
> > On 7/31/17, 12:30 PM, "Justin Leet" <ju...@gmail.com> wrote:
> >
> > That PR apparently got merged; I should have noted on the PR that
> this
> > thread got started.
> >
> > Now there's a new potentially a new question: If that change
> required a
> > vote, what's the way we want to handle it? Do we revert it or leave
> > it and
> > just follow-on with a PR for any changes we choose to make during
> > discussion / vote?
> >
> > Obviously, this is moot if the answer is we don't need a vote since
> > that PR
> > did have the appropriate +1's. At that point, I'd send an email
> > calling it
> > out and make the appropriate wiki changes for getting people setup.
> >
> > On Mon, Jul 31, 2017 at 1:50 PM, Justin Leet <ju...@gmail.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > There was a bit of confusion on code style on at least one ticket,
> > > indirectly related to https://github.com/apache/metron/pull/577.
> > For a
> > > refresher (and also because GitHub is being iffy today), that PR is
> > about
> > > moving to the Google Code Style as discussed in [DISCUSS] Code
> Style
> > > <https://lists.apache.org/thread.html/
> bd8afff9ad4fe83feb5e7fdfd5d136
> > 947665fd6e4e9856807d06e9a3@%3Cdev.metron.apache.org%3E>
> > >
> > > The feedback in that thread was positive, but no formal vote was
> > done.
> > > I've found at least one vote thread for dev guidelines in the past,
> > but
> > > it's also not part of the bylaws page itself. Does this require
> just
> > > discussion/community consensus, or does it require (or do we just
> > want) a
> > > vote? And is that in line with what other projects tend to do (if
> we
> > > choose to fo
> > >
> > > If we're of the opinion that it requires a vote, I'll happy to kick
> > up a
> > > discuss thread with the proposed change, get feedback, and run a
> > vote. It
> > > just delays when the change hits.
> > >
> >
> >
> >
>
Re: Code style change requires vote?
Posted by Justin Leet <ju...@gmail.com>.
Thanks a lot for the perspective, Matt, this is really good to have and I
appreciate you taking the time to review everything and give a solid
response.
I'm going to go ahead and give a specific email to the list outlining style
change and the instructions for improving the IDE experience. I'll double
check, but I believe I'll need wiki permissions to be able to update that
page.
If anybody has any concerns or other thoughts, feel free to respond, and
we'll figure out what else we want to do.
On Mon, Jul 31, 2017 at 9:36 PM, Matt Foley <mf...@hortonworks.com> wrote:
> Hi Justin,
> Technically, acceptance into the code base with appropriate review and
> +1’s signifies lazy consensus of all committers (since any committer can
> blackball a PR with a single justified -1).
>
> If you (or any community member) is concerned that people didn’t have
> sufficient opportunity to review, OR passed on the opportunity to review
> because they didn’t understand the importance of the issue, then it is a
> good-citizen thing to bring it up in the mailing list -- as you have now
> done. (You’re a gentleman and a scholar!)
>
> If the community has accepted enforcement of coding style via robot, then
> documenting that behavior seems an appropriate thing to do, certainly not
> requiring a vote on its own. (Please do!) So the question is, did the
> community _really_ accept it?
>
> I looked over the history of PR#577, and it sure looks to me like the
> community accepted it with (lengthy) review, due consideration, and two
> enthusiastic +1’s.
>
> As people actually experience the results, there’s always opportunity for
> second thoughts and fine tuning. I’d say go with the commit, and thanks
> for the contribution!
>
> --Matt
>
> On 7/31/17, 12:30 PM, "Justin Leet" <ju...@gmail.com> wrote:
>
> That PR apparently got merged; I should have noted on the PR that this
> thread got started.
>
> Now there's a new potentially a new question: If that change required a
> vote, what's the way we want to handle it? Do we revert it or leave
> it and
> just follow-on with a PR for any changes we choose to make during
> discussion / vote?
>
> Obviously, this is moot if the answer is we don't need a vote since
> that PR
> did have the appropriate +1's. At that point, I'd send an email
> calling it
> out and make the appropriate wiki changes for getting people setup.
>
> On Mon, Jul 31, 2017 at 1:50 PM, Justin Leet <ju...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > There was a bit of confusion on code style on at least one ticket,
> > indirectly related to https://github.com/apache/metron/pull/577.
> For a
> > refresher (and also because GitHub is being iffy today), that PR is
> about
> > moving to the Google Code Style as discussed in [DISCUSS] Code Style
> > <https://lists.apache.org/thread.html/bd8afff9ad4fe83feb5e7fdfd5d136
> 947665fd6e4e9856807d06e9a3@%3Cdev.metron.apache.org%3E>
> >
> > The feedback in that thread was positive, but no formal vote was
> done.
> > I've found at least one vote thread for dev guidelines in the past,
> but
> > it's also not part of the bylaws page itself. Does this require just
> > discussion/community consensus, or does it require (or do we just
> want) a
> > vote? And is that in line with what other projects tend to do (if we
> > choose to fo
> >
> > If we're of the opinion that it requires a vote, I'll happy to kick
> up a
> > discuss thread with the proposed change, get feedback, and run a
> vote. It
> > just delays when the change hits.
> >
>
>
>