[jira] [Commented] (SOLR-12587) Reuse Lucene's PriorityQueue for the ExportHandler

["Varun Thacker (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554688#comment-16554688 ] 

Varun Thacker commented on SOLR-12587:
--------------------------------------

Hi [~joel.bernstein]

I'm trying to understand why we need the {{cache}} array in {{SortQueue}}  . 

In reset could we simply do this? 
{code:java}
protected void reset() {
  Object[] heap = getHeapArray();
  for (int i=1; i< heap.length; i++) {
    heap[i] = proto.copy();
  }
  size = maxSize;
}{code}
 

> Reuse Lucene's PriorityQueue for the ExportHandler
> --------------------------------------------------
>
>                 Key: SOLR-12587
>                 URL: https://issues.apache.org/jira/browse/SOLR-12587
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Assignee: Varun Thacker
>            Priority: Major
>
> We have a priority queue in Lucene  {{org.apache.lucene.utilPriorityQueue}} . The Export Handler also implements a PriorityQueue {{org.apache.solr.handler.export.PriorityQueue}} . Both are obviously very similar with minor API differences. 
>  
> The aim here is to reuse Lucene's PQ and remove the Solr implementation. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org