You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ja...@apache.org on 2010/03/30 15:52:11 UTC
svn commit: r929143 - in /myfaces/core/trunk: api/src/main/java/javax/faces/component/_ExternalSpecifications.java api/src/main/java/javax/faces/validator/_ExternalSpecifications.java impl/src/main/java/org/apache/myfaces/util/ExternalSpecifications.java

Author: jakobk
Date: Tue Mar 30 13:52:11 2010
New Revision: 929143

URL: http://svn.apache.org/viewvc?rev=929143&view=rev
Log:
MYFACES-2621 BeanValidation does not work with Unified EL 2.2 (added volatile to variables in ExternalSpecifications)

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/_ExternalSpecifications.java
    myfaces/core/trunk/api/src/main/java/javax/faces/validator/_ExternalSpecifications.java
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/util/ExternalSpecifications.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/_ExternalSpecifications.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/_ExternalSpecifications.java?rev=929143&r1=929142&r2=929143&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/_ExternalSpecifications.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/_ExternalSpecifications.java Tue Mar 30 13:52:11 2010
@@ -36,8 +36,8 @@ final class _ExternalSpecifications
     //private static final Log log = LogFactory.getLog(BeanValidator.class);
     private static final Logger log = Logger.getLogger(_ExternalSpecifications.class.getName());
 
-    private static Boolean beanValidationAvailable;
-    //private static Boolean unifiedELAvailable;
+    private static volatile Boolean beanValidationAvailable;
+    //private static volatile Boolean unifiedELAvailable;
 
     /**
      * This method determines if Bean Validation is present.
@@ -96,7 +96,7 @@ final class _ExternalSpecifications
      * @return true if UEL is available, false otherwise.
      */
     /*
-    public static synchronized boolean isUnifiedELAvailable()
+    public static boolean isUnifiedELAvailable()
     {
         if (unifiedELAvailable == null)
         {

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/validator/_ExternalSpecifications.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/validator/_ExternalSpecifications.java?rev=929143&r1=929142&r2=929143&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/validator/_ExternalSpecifications.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/validator/_ExternalSpecifications.java Tue Mar 30 13:52:11 2010
@@ -40,8 +40,8 @@ final class _ExternalSpecifications
     //private static final Log log = LogFactory.getLog(BeanValidator.class);
     private static final Logger log = Logger.getLogger(_ExternalSpecifications.class.getName());
 
-    private static Boolean beanValidationAvailable;
-    private static Boolean unifiedELAvailable;
+    private static volatile Boolean beanValidationAvailable;
+    private static volatile Boolean unifiedELAvailable;
 
     /**
      * This method determines if Bean Validation is present.

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/util/ExternalSpecifications.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/util/ExternalSpecifications.java?rev=929143&r1=929142&r2=929143&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/util/ExternalSpecifications.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/util/ExternalSpecifications.java Tue Mar 30 13:52:11 2010
@@ -40,8 +40,8 @@ public final class ExternalSpecification
     //private static final Log log = LogFactory.getLog(BeanValidator.class);
     private static final Logger log = Logger.getLogger(ExternalSpecifications.class.getName());
 
-    private static Boolean beanValidationAvailable;
-    private static Boolean unifiedELAvailable;
+    private static volatile Boolean beanValidationAvailable;
+    private static volatile Boolean unifiedELAvailable;
 
     /**
      * This method determines if Bean Validation is present.