You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2009/02/12 13:54:45 UTC
[jira] Created: (TILES-365) Test webapp
"testimportattribute_inherit.jsp" test fails
Test webapp "testimportattribute_inherit.jsp" test fails
--------------------------------------------------------
Key: TILES-365
URL: https://issues.apache.org/struts/browse/TILES-365
Project: Tiles
Issue Type: Bug
Components: tiles-core, tiles-jsp (jsp support), tiles-test
Affects Versions: 2.1.2
Reporter: Antonio Petrelli
Assignee: Antonio Petrelli
Fix For: 2.1.3
The "testimportattribute_inherit.jsp" fails, because it displays:
* valueOne
* valueTwo
* valueThree
* valueOne
* valueTwo
* valueThree
* valueOne
* valueTwo
* valueThree
* valueFour
Instead of:
* valueOne
* valueTwo
* valueThree
* valueFour
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-365) Test webapp
"testimportattribute_inherit.jsp" test fails
Posted by "Lukasz Racon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46610#action_46610 ]
Lukasz Racon commented on TILES-365:
------------------------------------
Antonio,
while fixing this one I think that you have reintroduced TILES-340 - parent definitions do not have inheritance and wildcards resolved.
Revision 743737 changed this line:
protected Map<String, Definition> loadParentDefinitions(Locale parentLocale) {
- return loadRawDefinitionsFromURLs(parentLocale);
+ return loadDefinitionsFromURLs(parentLocale);
}
After deploying the application if the first user's locale is set to 'en_US' the ResolvingLocaleUrlDefinitionDAO loads 'null' then 'en' definitions, then it loads 'en_US' definitions.
ResolvingLocaleUrlDefinitionDAO.postDefinitionLoadOperations is called only for the 'en_US' definitions, while parent ('null' and 'en') locale definitions are never resolved (inheritance and wildcards). If next user has 'en' locale s/he gets NoSuchDefinitionException.
> Test webapp "testimportattribute_inherit.jsp" test fails
> --------------------------------------------------------
>
> Key: TILES-365
> URL: https://issues.apache.org/struts/browse/TILES-365
> Project: Tiles
> Issue Type: Bug
> Components: tiles-core
> Affects Versions: 2.1.2
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.3
>
>
> The "testimportattribute_inherit.jsp" fails, because it displays:
> * valueOne
> * valueTwo
> * valueThree
> * valueOne
> * valueTwo
> * valueThree
> * valueOne
> * valueTwo
> * valueThree
> * valueFour
> Instead of:
> * valueOne
> * valueTwo
> * valueThree
> * valueFour
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-365) Test webapp
"testimportattribute_inherit.jsp" test fails
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-365:
-----------------------------------
Component/s: (was: tiles-jsp (jsp support))
(was: tiles-test)
The problem is in CachingLocaleUrlDefinitionDAO and ResolvingLocaleUrlDefinitionDAO.
In particular, in the latter one, the definitions are loaded and immediately resolved (speaking of definition inheritance).
In case of multiple locale, the URLs are loaded (grouped by locale) and then resolved starting from the "null" locale to the chosen locale.
For example, if I have "it_IT" locale:
* definitions of "null" locale are loaded, then resolved;
* definitions of "it" locale are loaded, then resolved;
* definitions of "it_IT" locale are loaded, then resolved.
These definitions MUST be resolved only at the end, not 3 times.
> Test webapp "testimportattribute_inherit.jsp" test fails
> --------------------------------------------------------
>
> Key: TILES-365
> URL: https://issues.apache.org/struts/browse/TILES-365
> Project: Tiles
> Issue Type: Bug
> Components: tiles-core
> Affects Versions: 2.1.2
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.3
>
>
> The "testimportattribute_inherit.jsp" fails, because it displays:
> * valueOne
> * valueTwo
> * valueThree
> * valueOne
> * valueTwo
> * valueThree
> * valueOne
> * valueTwo
> * valueThree
> * valueFour
> Instead of:
> * valueOne
> * valueTwo
> * valueThree
> * valueFour
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TILES-365) Test webapp
"testimportattribute_inherit.jsp" test fails
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/TILES-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli closed TILES-365.
----------------------------------
Resolution: Fixed
Now the list attributes are inherited only once.
> Test webapp "testimportattribute_inherit.jsp" test fails
> --------------------------------------------------------
>
> Key: TILES-365
> URL: https://issues.apache.org/struts/browse/TILES-365
> Project: Tiles
> Issue Type: Bug
> Components: tiles-core
> Affects Versions: 2.1.2
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.1.3
>
>
> The "testimportattribute_inherit.jsp" fails, because it displays:
> * valueOne
> * valueTwo
> * valueThree
> * valueOne
> * valueTwo
> * valueThree
> * valueOne
> * valueTwo
> * valueThree
> * valueFour
> Instead of:
> * valueOne
> * valueTwo
> * valueThree
> * valueFour
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.