You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by David Blevins <da...@gmail.com> on 2015/02/01 06:11:09 UTC
DependenceValidationTest
Seems the majority of checks were commented out in this commit:
- https://github.com/apache/tomee/commit/6bbf5ce32d5a408bde13eefe393c6b1f3381a48d#diff-f6aa0817f9f5b87a8bae7a33578bc10f
Any particular reason?
The idea of those checks is to enforce constraints such as the singleton container should be independent and not have dependencies on the stateless container, etc. Making it possible for people to run server with just some containers (say singletons) and not others (MDBs or CMP for example)
-David
Re: DependenceValidationTest
Posted by Romain Manni-Bucau <rm...@gmail.com>.
It is done if i didnt forget to push
Le 1 févr. 2015 20:45, "David Blevins" <da...@gmail.com> a écrit :
> Awesome. Let's backport that for safe measure.
>
> Thanks again for the ASM5 upgrade work. That's always so painful.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> On Feb 1, 2015, at 2:57 AM, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> > no real reason - guess it was forgotten when supporting j8 cause it
> > was broken because of new asm api - reactivated on 2.x (only issue I
> > got was the new containerclassesfilter which is not in 1.7 so we
> > shouldnt have issues to backport it)
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau
> > http://www.tomitribe.com
> > http://rmannibucau.wordpress.com
> > https://github.com/rmannibucau
> >
> >
> > 2015-02-01 6:11 GMT+01:00 David Blevins <da...@gmail.com>:
> >> Seems the majority of checks were commented out in this commit:
> >>
> >> -
> https://github.com/apache/tomee/commit/6bbf5ce32d5a408bde13eefe393c6b1f3381a48d#diff-f6aa0817f9f5b87a8bae7a33578bc10f
> >>
> >> Any particular reason?
> >>
> >> The idea of those checks is to enforce constraints such as the
> singleton container should be independent and not have dependencies on the
> stateless container, etc. Making it possible for people to run server with
> just some containers (say singletons) and not others (MDBs or CMP for
> example)
> >>
> >>
> >> -David
> >>
>
>
Re: DependenceValidationTest
Posted by David Blevins <da...@gmail.com>.
Awesome. Let's backport that for safe measure.
Thanks again for the ASM5 upgrade work. That's always so painful.
--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
On Feb 1, 2015, at 2:57 AM, Romain Manni-Bucau <rm...@gmail.com> wrote:
> no real reason - guess it was forgotten when supporting j8 cause it
> was broken because of new asm api - reactivated on 2.x (only issue I
> got was the new containerclassesfilter which is not in 1.7 so we
> shouldnt have issues to backport it)
>
>
> Romain Manni-Bucau
> @rmannibucau
> http://www.tomitribe.com
> http://rmannibucau.wordpress.com
> https://github.com/rmannibucau
>
>
> 2015-02-01 6:11 GMT+01:00 David Blevins <da...@gmail.com>:
>> Seems the majority of checks were commented out in this commit:
>>
>> - https://github.com/apache/tomee/commit/6bbf5ce32d5a408bde13eefe393c6b1f3381a48d#diff-f6aa0817f9f5b87a8bae7a33578bc10f
>>
>> Any particular reason?
>>
>> The idea of those checks is to enforce constraints such as the singleton container should be independent and not have dependencies on the stateless container, etc. Making it possible for people to run server with just some containers (say singletons) and not others (MDBs or CMP for example)
>>
>>
>> -David
>>
Re: DependenceValidationTest
Posted by Romain Manni-Bucau <rm...@gmail.com>.
no real reason - guess it was forgotten when supporting j8 cause it
was broken because of new asm api - reactivated on 2.x (only issue I
got was the new containerclassesfilter which is not in 1.7 so we
shouldnt have issues to backport it)
Romain Manni-Bucau
@rmannibucau
http://www.tomitribe.com
http://rmannibucau.wordpress.com
https://github.com/rmannibucau
2015-02-01 6:11 GMT+01:00 David Blevins <da...@gmail.com>:
> Seems the majority of checks were commented out in this commit:
>
> - https://github.com/apache/tomee/commit/6bbf5ce32d5a408bde13eefe393c6b1f3381a48d#diff-f6aa0817f9f5b87a8bae7a33578bc10f
>
> Any particular reason?
>
> The idea of those checks is to enforce constraints such as the singleton container should be independent and not have dependencies on the stateless container, etc. Making it possible for people to run server with just some containers (say singletons) and not others (MDBs or CMP for example)
>
>
> -David
>