You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by me...@apache.org on 2007/03/12 23:26:19 UTC

svn commit: r517429 - in /incubator/tuscany/java/sca/kernel: core/src/main/java/org/apache/tuscany/core/builder/physical/ core/src/main/java/org/apache/tuscany/core/component/instancefactory/ core/src/main/java/org/apache/tuscany/core/component/instanc...

Author: meerajk
Date: Mon Mar 12 15:26:18 2007
New Revision: 517429

URL: http://svn.apache.org/viewvc?view=rev&rev=517429
Log:
Removed unnecessary typing in registry

Modified:
    incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/physical/DefaultPhysicalComponentBuilderRegistry.java
    incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/IFProviderBuilderRegistry.java
    incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/impl/DefaultIFProviderBuilderRegistry.java
    incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/builder/physical/PhysicalComponentBuilderRegistry.java

Modified: incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/physical/DefaultPhysicalComponentBuilderRegistry.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/physical/DefaultPhysicalComponentBuilderRegistry.java?view=diff&rev=517429&r1=517428&r2=517429
==============================================================================
--- incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/physical/DefaultPhysicalComponentBuilderRegistry.java (original)
+++ incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/physical/DefaultPhysicalComponentBuilderRegistry.java Mon Mar 12 15:26:18 2007
@@ -29,34 +29,32 @@
 
 /**
  * Default map-based implementation of the physical component builder registry.
- * <p/>
- * TODO may be we can factor out all the registries into a parameterized one.
- *
+ * <p/> TODO may be we can factor out all the registries into a parameterized
+ * one.
+ * 
  * @version $Rev$ $Date$
  */
 public class DefaultPhysicalComponentBuilderRegistry implements PhysicalComponentBuilderRegistry {
 
     // Internal cache
-    private Map<Class<?>,
-        PhysicalComponentBuilder<? extends PhysicalComponentDefinition, ? extends Component>> registry =
-        new ConcurrentHashMap<Class<?>,
-            PhysicalComponentBuilder<? extends PhysicalComponentDefinition, ? extends Component>>();
+    private Map<Class<?>, PhysicalComponentBuilder<? extends PhysicalComponentDefinition, ? extends Component>> registry =
+        new ConcurrentHashMap<Class<?>, PhysicalComponentBuilder<? extends PhysicalComponentDefinition, ? extends Component>>();
 
     /**
      * Registers a physical component builder.
-     *
-     * @param <PCD>           Type of the physical component definition.
+     * 
+     * @param <PCD> Type of the physical component definition.
      * @param definitionClass Class of the physical component definition.
-     * @param builder         Builder for the physical component definition.
+     * @param builder Builder for the physical component definition.
      */
-    public <PCD extends PhysicalComponentDefinition,
-        C extends Component> void register(Class<?> definitionClass, PhysicalComponentBuilder<PCD, C> builder) {
+    public <PCD extends PhysicalComponentDefinition> void register(Class<PCD> definitionClass,
+                                                                   PhysicalComponentBuilder<PCD, ?> builder) {
         registry.put(definitionClass, builder);
     }
 
     /**
      * Builds a physical component from component definition.
-     *
+     * 
      * @param componentDefinition Component definition.
      * @return Component to be built.
      */

Modified: incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/IFProviderBuilderRegistry.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/IFProviderBuilderRegistry.java?view=diff&rev=517429&r1=517428&r2=517429
==============================================================================
--- incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/IFProviderBuilderRegistry.java (original)
+++ incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/IFProviderBuilderRegistry.java Mon Mar 12 15:26:18 2007
@@ -17,8 +17,7 @@
      * @param ifpdClass Instance factory provider definition class.
      * @param builder Instance factory provider builder.
      */
-    <IFPD extends InstanceFactoryProviderDefinition, IFP extends InstanceFactoryProvider> void register(Class<IFPD> ifpdClass,
-                                                                   IFProviderBuilder<IFP, IFPD> builder);
+    <IFPD extends InstanceFactoryProviderDefinition> void register(Class<IFPD> ifpdClass, IFProviderBuilder<?, IFPD> builder);
     
     /**
      * Builds an instnace factory provider from a definition.

Modified: incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/impl/DefaultIFProviderBuilderRegistry.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/impl/DefaultIFProviderBuilderRegistry.java?view=diff&rev=517429&r1=517428&r2=517429
==============================================================================
--- incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/impl/DefaultIFProviderBuilderRegistry.java (original)
+++ incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/component/instancefactory/impl/DefaultIFProviderBuilderRegistry.java Mon Mar 12 15:26:18 2007
@@ -15,7 +15,6 @@
  * Default implementation of the registry.
  * 
  * @version $Revison$ $Date$
- *
  */
 public class DefaultIFProviderBuilderRegistry implements IFProviderBuilderRegistry {
 
@@ -34,8 +33,7 @@
     /**
      * Registers the builder.
      */
-    public <IFPD extends InstanceFactoryProviderDefinition, IFP extends InstanceFactoryProvider> void register(Class<IFPD> ifpdClass,
-                                                                                                               IFProviderBuilder<IFP, IFPD> builder) {
+    public <IFPD extends InstanceFactoryProviderDefinition> void register(Class<IFPD> ifpdClass, IFProviderBuilder<?, IFPD> builder) {
         registry.put(ifpdClass, builder);
     }
 

Modified: incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/builder/physical/PhysicalComponentBuilderRegistry.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/builder/physical/PhysicalComponentBuilderRegistry.java?view=diff&rev=517429&r1=517428&r2=517429
==============================================================================
--- incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/builder/physical/PhysicalComponentBuilderRegistry.java (original)
+++ incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/builder/physical/PhysicalComponentBuilderRegistry.java Mon Mar 12 15:26:18 2007
@@ -24,25 +24,24 @@
 
 /**
  * A registry of physical component builders.
- *
+ * 
  * @version $Rev$ $Date$
  */
 public interface PhysicalComponentBuilderRegistry {
 
     /**
      * Registers a physical component builder.
-     *
-     * @param <PCD>           Type of the physical component definition.
+     * 
+     * @param <PCD> Type of the physical component definition.
      * @param definitionClass Class of the physical component definition.
-     * @param builder         Builder for the physical component definition.
+     * @param builder Builder for the physical component definition.
      */
-    <PCD extends PhysicalComponentDefinition, C extends Component>
-        void register(Class<?> definitionClass,
-                      PhysicalComponentBuilder<PCD, C> builder);
+    <PCD extends PhysicalComponentDefinition> void register(Class<PCD> definitionClass,
+                                                            PhysicalComponentBuilder<PCD, ?> builder);
 
     /**
      * Builds a physical component from component definition.
-     *
+     * 
      * @param componentDefinition Component definition.
      * @return Component to be built.
      */



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org