You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/23 17:26:58 UTC
[jira] [Created] (BOOKKEEPER-477) In ReadOnlyBookieTest, we should
wait for the bookie to die before asserting on it
Ivan Kelly created BOOKKEEPER-477:
-------------------------------------
Summary: In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
Key: BOOKKEEPER-477
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
Attachments: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-477) In ReadOnlyBookieTest, we
should wait for the bookie to die before asserting on it
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504532#comment-13504532 ]
Flavio Junqueira commented on BOOKKEEPER-477:
---------------------------------------------
We might have discussed this in the past, but isn't there perhaps a more reliable way of detecting that a bookie has shut down? Using time is prone to false positives and often increases the time to run tests.
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-477) In ReadOnlyBookieTest, we
should wait for the bookie to die before asserting on it
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504667#comment-13504667 ]
Flavio Junqueira commented on BOOKKEEPER-477:
---------------------------------------------
btw, the patch doesn't apply cleanly, since it hasn't been generated against the project root. I'll commit it, but it would be good to upload one that applies cleanly.
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-477) In ReadOnlyBookieTest, we should
wait for the bookie to die before asserting on it
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-477:
----------------------------------
Attachment: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-477) In ReadOnlyBookieTest, we
should wait for the bookie to die before asserting on it
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504782#comment-13504782 ]
Hudson commented on BOOKKEEPER-477:
-----------------------------------
Integrated in bookkeeper-trunk #824 (See [https://builds.apache.org/job/bookkeeper-trunk/824/])
BOOKKEEPER-477: In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it (ivank via fpj) (Revision 1414233)
Result = FAILURE
fpj :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ReadOnlyBookieTest.java
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-BOOKKEEPER-477-ReadOnlyBookieTest-Give-the-bookie-a-.patch, 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-477) In ReadOnlyBookieTest, we
should wait for the bookie to die before asserting on it
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504536#comment-13504536 ]
Hadoop QA commented on BOOKKEEPER-477:
--------------------------------------
Testing JIRA BOOKKEEPER-477
WARNING: Running test-patch on a dirty local svn workspace
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-477) In ReadOnlyBookieTest, we
should wait for the bookie to die before asserting on it
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504822#comment-13504822 ]
Hadoop QA commented on BOOKKEEPER-477:
--------------------------------------
Testing JIRA BOOKKEEPER-477
WARNING: Running test-patch on a dirty local svn workspace
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-BOOKKEEPER-477-ReadOnlyBookieTest-Give-the-bookie-a-.patch, 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-477) In ReadOnlyBookieTest, we should
wait for the bookie to die before asserting on it
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-477:
----------------------------------
Attachment: 0002-BOOKKEEPER-477-ReadOnlyBookieTest-Give-the-bookie-a-.patch
Should apply cleanly now.
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-BOOKKEEPER-477-ReadOnlyBookieTest-Give-the-bookie-a-.patch, 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-477) In ReadOnlyBookieTest, we
should wait for the bookie to die before asserting on it
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504629#comment-13504629 ]
Ivan Kelly commented on BOOKKEEPER-477:
---------------------------------------
We have a method, Bookie#isAlive(). This is what the patch checks, in a loop.
> In ReadOnlyBookieTest, we should wait for the bookie to die before asserting on it
> ----------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-477
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-477
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0002-ReadOnlyBookieTest-Give-the-bookie-a-chance-to-die.patch
>
>
> Right now we assert immediately, so the bookie thread has no chance to die. We should only assert after giving it a chance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira