[jira] [Commented] (STORM-2517) storm-hdfs writers can't be subclassed

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144451#comment-16144451 ] 

Robert Joseph Evans commented on STORM-2517:
--------------------------------------------

Thanks [~Angus-slalom],

I merged this into master and branch-1.x

> storm-hdfs writers can't be subclassed
> --------------------------------------
>
>                 Key: STORM-2517
>                 URL: https://issues.apache.org/jira/browse/STORM-2517
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-hdfs
>    Affects Versions: 1.1.0
>            Reporter: Angus Helm
>            Assignee: Angus Helm
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> {{HdfsBolt.makeNewWriter()}} returns an AbstractHDFSWriter instead of an interface. AbstractHDFSWriter is public but its constructor is package-private so it can't actually be subclassed unless your class is in the {{org.apache.storm.hdfs.common}} package. I subclassed HDFSWriter but it required some workarounds.
> Also {{AbstractHDFSWriter.offset}} is package-private and write() is final, so there is no way for a subclass to control or update the offset after {{doWrite()}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)