You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (Created) (JIRA)" <ji...@apache.org> on 2011/10/03 17:00:35 UTC
[jira] [Created] (SHINDIG-1634) Potential test failure in
GadgetHandlerTest
Potential test failure in GadgetHandlerTest
-------------------------------------------
Key: SHINDIG-1634
URL: https://issues.apache.org/jira/browse/SHINDIG-1634
Project: Shindig
Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Ryan Baxter
Priority: Minor
Attachments: issue-1634.patch
GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1634) Potential test failure in
GadgetHandlerTest
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119346#comment-13119346 ]
jiraposter@reviews.apache.org commented on SHINDIG-1634:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/
-----------------------------------------------------------
Review request for shindig, Henry Saputra and Dan Dumont.
Summary
-------
GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
This addresses bug SHINDIG-1634.
https://issues.apache.org/jira/browse/SHINDIG-1634
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236
Diff: https://reviews.apache.org/r/2149/diff
Testing
-------
Ran mvn build
Thanks,
Ryan
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1634) Potential test failure in
GadgetHandlerTest
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119378#comment-13119378 ]
jiraposter@reviews.apache.org commented on SHINDIG-1634:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/#review2264
-----------------------------------------------------------
Ship it!
For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding :)
- Paul
On 2011-10-03 15:01:39, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2149/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-03 15:01:39)
bq.
bq.
bq. Review request for shindig, Henry Saputra and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
bq.
bq.
bq. This addresses bug SHINDIG-1634.
bq. https://issues.apache.org/jira/browse/SHINDIG-1634
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236
bq.
bq. Diff: https://reviews.apache.org/r/2149/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran mvn build
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1634) Potential test failure in
GadgetHandlerTest
Posted by "Ryan Baxter (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter resolved SHINDIG-1634.
----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Committed revision 1178441.
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1634) Potential test failure in
GadgetHandlerTest
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1634.
---------------------------------
part of 2.5.0-beta1 release.
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0-beta1
> Reporter: Ryan Baxter
> Priority: Minor
> Fix For: 2.5.0-beta1
>
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1634) Potential test failure in
GadgetHandlerTest
Posted by "Ryan Baxter (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1634:
---------------------------------
Attachment: issue-1634.patch
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1634) Potential test failure in
GadgetHandlerTest
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119387#comment-13119387 ]
jiraposter@reviews.apache.org commented on SHINDIG-1634:
--------------------------------------------------------
bq. On 2011-10-03 16:07:31, Paul Lindner wrote:
bq. > For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding :)
bq. >
Thanks Paul. We would all like more time coding.
Committed revision 1178441.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/#review2264
-----------------------------------------------------------
On 2011-10-03 15:01:39, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2149/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-03 15:01:39)
bq.
bq.
bq. Review request for shindig, Henry Saputra and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
bq.
bq.
bq. This addresses bug SHINDIG-1634.
bq. https://issues.apache.org/jira/browse/SHINDIG-1634
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236
bq.
bq. Diff: https://reviews.apache.org/r/2149/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran mvn build
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Potential test failure in GadgetHandlerTest
> -------------------------------------------
>
> Key: SHINDIG-1634
> URL: https://issues.apache.org/jira/browse/SHINDIG-1634
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: issue-1634.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira