You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rp...@apache.org on 2023/02/10 16:17:54 UTC

svn commit: r1907565 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

Author: rpluem
Date: Fri Feb 10 16:17:54 2023
New Revision: 1907565

URL: http://svn.apache.org/viewvc?rev=1907565&view=rev
Log:
* Optimize code: We know that we already have a valid encoding string,
  because we just decoded it. Hence just copy what we have instead of
  redoing it.

Modified:
    httpd/httpd/trunk/modules/proxy/proxy_util.c

Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=1907565&r1=1907564&r2=1907565&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
+++ httpd/httpd/trunk/modules/proxy/proxy_util.c Fri Feb 10 16:17:54 2023
@@ -261,12 +261,13 @@ PROXY_DECLARE(char *)ap_proxy_canonenc(a
                 return NULL;
             }
             ch = ap_proxy_hex2c(&x[i + 1]);
-            i += 2;
             if (ch != 0 && strchr(reserved, ch)) {  /* keep it encoded */
-                ap_proxy_c2hex(ch, &y[j]);
-                j += 2;
+                y[j++] = x[i++];
+                y[j++] = x[i++];
+                y[j] = x[i];
                 continue;
             }
+            i += 2;
         }
 /* recode it, if necessary */
         if (!apr_isalnum(ch) && !strchr(allowed, ch)) {